Repository navigation
Fix the section C cleanup review findings - #842
Merged
Merged
Conversation
SaladDay
force-pushed
the
finish-the-section-c-cleanup-review-fixes
branch
from
October 23, 2026 19:45
6492510 to
48f3aaa
Compare
- request_timeout has a producer: Codex passes a provider's error.code or error.type through NormalizeEngineFailure. Restore it in the protocol, Core observations, diagnostics, client, Web and docs. - Migration 000004 no longer narrows the provider error-code constraint, so databases holding request_timeout rows can apply it; 000006 restores the constraint where the earlier 000004 already ran. - Core records the provisioning step harness when the selected Harness is unavailable; the diagnostics contract, the client validator and Web now accept and label it.
- Delete the Environment and hosted acceptance helpers that no runner imports on main, and the doc sentences that named them. - Drop the unread session_id column from ListEnrolledRuntimeBindings and the removed bootstrap fields from the onboarding smoke's fake Core. - Remove the harness-onboarding row for the deleted unsupported_test.go files. - Restore the Settings group names in the Web overview, the staging cleanup mechanism in the installer guide and the explicit heading-anchor rule for translations. - Scope the backup note to the original node identities and link checkpoint transfer for other nodes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the section C cleanup (#827–#832) from its blind review.
error.code/error.typethroughNormalizeEngineFailure. Migration 000004 no longer narrows the provider error-code constraint, so a database holdingrequest_timeoutrows can apply it. 000007 restores the constraint where the earlier 000004 already ran. Verified on a scratch database: baseline 000001–000003, insert arequest_timeoutrow, then 000004–000007 apply and a newrequest_timeoutrow is accepted.step: harnesswhen the selected Harness is unavailable. The diagnostics contract, the client validator and Web now accept and label it; before this change, the client returnedinvalidAdminResponsefor such a Session.services/core/testshelpers that no runner imports on main are gone: nineofficial_environment_*, twoofficial_hosted_*_nativeandsession_cleanup.official_session_artifacts.pyis imported by a Go integration test and stays. Also dropped: the unreadsession_idcolumn fromListEnrolledRuntimeBindings, and the removed bootstrap fields from the smoke's fake Core.{#id}rule for translations, the backup note scoped to the original node identities, and the staleunsupported_test.gorow removed.Checks:
go build ./...;go veton Core andinternal; focused Go tests forproto,modelconfigurationandapi;make check-sqlc;make check-openapi; client diagnostics vitest; Webtsc;website/tests/translations.test.mjshash checks. The structure subtest needsvitepress, which isn't installed locally.Need help on this PR? Tag
@codesmith-botwith what you need.