Open workspace confirmation from the FAB on Account and Insights tabs

[MelvinBot]

Explanation of Change

The FAB "New workspace" item opens the workspace/confirmation dynamic route on top of whatever screen is active. That route only allowed a short list of entry screens (HOME, INBOX, REPORT, SEARCH.ROOT, WORKSPACES_LIST, SETTINGS.ROOT).

On a wide layout, the Account tab lands on settings/profile (SETTINGS.PROFILE.ROOT), and the Insights tab is insights/:dashboardID (INSIGHTS). Neither is in the list, so getStateFromPath rejects the suffix and the path falls through to the Not Found page.

The FAB is reachable from every tab, so this PR sets DYNAMIC_ROUTES.WORKSPACE_CONFIRMATION.entryScreens to ['*'], which several other global dynamic routes already use. The child routes (currency, plan type, owner) key off WORKSPACE_CONFIRMATION.DYNAMIC_ROOT and need no change.

Added a regression test that resolves the real route state for settings/profile/workspace/confirmation and insights/spend/workspace/confirmation. Both returned not-found before this change and now resolve to the confirmation screen.

AI web verification (wide layout, local dev build)

• Account > Profile → FAB > New workspace opens Confirm Workspace:
  
• The Default currency row on that page opens the currency selector:
  
• Inbox → FAB > New workspace still works:
  
• Insights tab was not available on the test account, so it was covered by the unit test only.

Fixed Issues

$ #102095
PROPOSAL: #102095 (comment)

Tests

Same as QA Steps

• Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

1. Go to staging.new.expensify.com
2. Create a new Gmail account.
3. Complete onboarding with Something else intent.
4. Go to Account.
5. Open FAB > New workspace.
6. New workspace confirm page will open.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[MelvinBot]

🤖 Android test steps verification results: ⚠️ partial

On standalone Android, FAB > New workspace opens the Confirm Workspace page from the Account tab and from Inbox, and the currency selector opens from that page. Two steps could not run as written on this phone-sized emulator: the Insights tab is beta-gated and missing for this account, and the Profile sub-page has no FAB in the narrow layout.

Step	Status
From the Account tab, FAB > New workspace opens the Confirm Workspace page (no Not Found page) Tapped the Account tab, then FAB > New workspace. The Confirm Workspace page opened with the Workspace name field and the Default currency row (USD - $). No Not Found page appeared.	✅
On the Confirm Workspace page, tapping Default currency opens the currency selector Tapped the Default currency row. A searchable currency list opened with USD selected.	✅
Account > Profile, then FAB > New workspace opens Confirm Workspace (not Not Found) Account > Profile opened. In the narrow phone layout, Profile is a pushed sub-screen with no tab bar or FAB, so the FAB tap could not be triggered. This is expected narrow-layout behavior, unrelated to this PR. The PR's unit test covers the settings/profile route.	⚠️
Insights tab, then FAB > New workspace opens Confirm Workspace (not Not Found) The tab bar shows only Home, Inbox, Spend, Workspaces, and Account. The Insights tab needs the insightsPage beta, which this test account does not have, so this step was not testable.	⚠️
Regression: from the Inbox tab, FAB > New workspace still opens Confirm Workspace Tapped the Inbox tab, then FAB > New workspace. The same Confirm Workspace page opened. No regression.	✅

---

view run · view recording

[MelvinBot]

The failing ESLint check is unrelated to this PR, so I didn't push a change.

Analysis: The only lint error is max-lines in src/libs/PolicyUtils.ts (4,039 lines, limit 4,000). This PR doesn't touch that file. main has the same error: Resolve the member's own policy role when checking room member removal took the file from 3,999 to 4,039 lines when it merged.

Fix in progress: [No QA] Move NetSuite helpers out of PolicyUtils to fix max-lines lint failure is open. After it merges, merge main into this branch and the check should pass.

Evidence: This PR changes only src/ROUTES.ts and tests/navigation/workspaceConfirmationEntryScreensTest.ts. The failure points to src/libs/PolicyUtils.ts:4001.

Check independent approval is also failing. That check needs a reviewer approval, not a code change.

---

view run

[MelvinBot]

🤖 Web test steps verification results: ⚠️ partial

On web (wide layout), FAB > New workspace opens the Confirm Workspace page from Account > Profile and from Inbox, with no Not Found page, and the Default currency row opens the currency selector. The Insights tab is not available for this test account, so that step could not run.

Step	Status
Account tab (Profile) > FAB > New workspace opens the Confirm Workspace page, not Not Found The Account tab landed on Account > Profile. FAB > New workspace opened the Confirm Workspace page with the Workspace name field, the Default currency row (USD - $), and a Confirm button. No Not Found page appeared.	✅
The Default currency row opens the currency selector Clicked the Default currency row. The Default currency page opened with a search field and a currency list, USD selected.	✅
Insights tab > FAB > New workspace opens the Confirm Workspace page Not testable. The tab list shows only Home, Inbox, Spend, Workspaces, and Account. The Insights tab needs the insightsPage beta, which this test account does not have.	⚠️
Regression: Inbox tab > FAB > New workspace still opens the Confirm Workspace page From Inbox, FAB > New workspace opened the same Confirm Workspace page. No regression.	✅
No JS console errors in this flow The test browser could not read the JS console. No error banners, crash screens, or broken UI appeared during the flow. This does not replace a real console check.	⚠️

---

view run · view recording

[dmkt9]

@MelvinBot merge the latest main branch to fix the eslint failure

[MelvinBot]

Merged the latest main into this branch (0d8c8af). There were no conflicts.

The ESLint failure was max-lines in src/libs/PolicyUtils.ts: 4,039 lines against a 4,000 limit. This PR doesn't touch that file. On the latest main it is 3,840 lines, so the merge should fix the check. CI is running again now.

---

view run

[dmkt9]

@MelvinBot update your checklist:

1. Check all checkboxes
2. Update the Tests section and Offline tests section to Same as QA Steps
3. Update the QA Steps to:

1. Go to staging.new.expensify.com
2. Create a new Gmail account.
3. Complete onboarding with Something else intent.
4. Go to Account.
5. Open FAB > New workspace.
6. New workspace confirm page will open.

[MelvinBot]

Updated the PR description:

• Checked every checkbox.
• Set Tests and Offline tests to Same as QA Steps.
• Replaced QA Steps with your six steps.

---

view run

[MelvinBot]

The failing check is unrelated to this PR, so I didn't push a fix.

Analysis: test (job 6) fails in tests/unit/SelectFeaturesEmptyTagGroupTest.tsx (3 tests) with ReferenceError: Request is not defined, thrown from src/libs/HttpUtils.ts when the test reaches a real fetch. This PR only changes src/ROUTES.ts and adds tests/navigation/workspaceConfirmationEntryScreensTest.ts. Neither is on that test's code path.

Evidence: The same 3 tests fail the same way on other unrelated PRs' Jest runs, starting around 14:11 UTC today. Jest runs before 14:01 UTC passed. Two PRs merged to main in that window and are the likely cause, but I haven't confirmed which one:

• [Onyx bump] Bump react-native-onyx to 3.0.115
• feat: support inline editing for workspace settings tables

Next step: Once main is fixed, merge main into this branch or re-run the job. The other failing check, Check independent approval, is expected until a reviewer approves.

---

view run

[MelvinBot]

The failing check is still unrelated to this PR, so I didn't push a fix. This PR hasn't been re-run since my last comment.

Analysis: test (job 6) fails in tests/unit/SelectFeaturesEmptyTagGroupTest.tsx with ReferenceError: Request is not defined. The test reaches a real network fetch. This PR only changes src/ROUTES.ts and adds a navigation test. Other unrelated PRs fail the same way.

Fix in progress on main: [No QA] Mock fetch in tests that render the GetRules prefetch mocks fetch in this exact test file. That points to a GetRules prefetch as the cause, not the two PRs I listed in my last comment.

Next step: After that PR merges, merge main into this branch or re-run test (job 6). Check independent approval will pass once a reviewer approves.

---

view run

[dmkt9]

@MelvinBot mark this PR as ready

[MelvinBot]

I couldn't mark this PR as ready. The command to change its draft status was blocked in my environment.

You can do it yourself: click Ready for review at the bottom of the PR page.

---

view run

[melvin-bot]

@dmkt9 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-07T11:44:21.730763Z	0d8c8af	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[dmkt9]

@MelvinBot merge the latest main branch into this PR

[MelvinBot]

I merged the latest main into this PR and pushed it in b12fb02. The merge had no conflicts.

---

view run

[melvin-bot]

@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[dmkt9]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

chrome.mp4

[dmkt9]

LGTM

[MelvinBot]

No fix needed. All checks now pass on the latest commit (b12fb02, the merge of main). The only checks still running are the perf tests and the review checklists.

Details

• The last real failure was Jest Unit Tests on 0d8c8af0. It failed in tests/unit/SelectFeaturesEmptyTagGroupTest.tsx, which this PR does not touch. The PR only changes src/ROUTES.ts and tests/navigation/workspaceConfirmationEntryScreensTest.ts.
• That failure came from main. It passed after main was merged into this branch.
• The earlier ESLint check failure on 563e5bf5 was fixed by later commits and passes now.

---

view run

[github-actions]

🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #102625.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-0f4c259-c3baeb0-9422d7735835d34ade0925c9b6e5ba0e642158f4/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-0f4c259-c3baeb0-801d8316f7cf92b333fa540647f2e790ab9c1c84/index.html

Web 🕸️
https://102625.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.5.8-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[MelvinBot]

No help site update needed. This is a bug fix: New workspace in the FAB now opens the workspace confirmation page from the Account and Insights tabs instead of a Not Found page. That's what users already expect, and no help article says otherwise.

---

view run