Skip to content

[Due for payment 2026-10-21] [$175] Not here page opens when creating new workspace from FAB on Account and Insights tab #102095

Open
Open
[Due for payment 2026-10-21] [$175] Not here page opens when creating new workspace from FAB on Account and Insights tab#102095
Assignees
mjasikowskidmkt9
Labels
BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Description

@applause-bot
applause-bot
bot
opened on Sep 23, 2026

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.

Version Number: 9.4.92-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-76906/41237401/1789560056?sort=-identifier
Email or phone of affected tester (no customers): njosdnjonsdjiojiosj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new Gmail account.
  3. Complete onboarding with Something else intent.
  4. Go to Account.
  5. Open FAB > New workspace.

Expected Result:

New workspace confirm page will open.

Actual Result:

Not here page opens when creating new workspace from FAB on Account tab.
This issue also happens on Insights tab when insightPage beta is enabled.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7267310_1790170537256.7.1.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7267310

Issue OwnerCurrent Issue Owner: @dmkt9
Upwork Automation - Do Not Edit

Activity

  1. applause-bot
    added
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 23, 2026

  2. applause-bot commented on Sep 23, 2026

    @applause-bot
    applause-botbot
    on Sep 23, 2026
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/e651876098750de3d5c0040c96408e30052ef7ba2eb877ea89e85b8d117742e5

  3. gleitebr
    added this to #expensify-bugson Sep 23, 2026

  4. MelvinBot commented on Sep 23, 2026

    @MelvinBot
    MelvinBot
    on Sep 23, 2026
    Contributor

    Proposal

    What is the root cause of that problem?

    WORKSPACE_CONFIRMATION is a dynamic route — it is appended as a suffix to whatever path is currently active, and it is only allowed to open from a whitelist of screens (src/ROUTES.ts:235-238):

    entryScreens: [SCREENS.HOME, SCREENS.INBOX, SCREENS.REPORT, SCREENS.SEARCH.ROOT, SCREENS.WORKSPACES_LIST, SCREENS.SETTINGS.ROOT],

    The FAB item calls createDynamicRoute(...) with no basePath (NewWorkspaceMenuItem.tsx:58), so the base path is whatever getActiveRoute() returns (createDynamicRoute.ts:77). On the two broken tabs that active path resolves to a screen that is not in the whitelist:

    • Account tab, wide layout: SettingsSplitNavigator pushes SCREENS.SETTINGS.PROFILE.ROOT as the central pane and makes it the focused route (SettingsSplitNavigator.tsx:46, SplitRouter.ts:117). The URL is settings/profile, not settings, so the built route is settings/profile/workspace/confirmation. SETTINGS.PROFILE.ROOT is not whitelisted — only SETTINGS.ROOT is.
    • Insights tab: the active path is insights/:dashboardID → focused route SCREENS.INSIGHTS, which is not in the list at all.

    The whitelist check fails at getStateFromPath.ts:49, the path falls through to React Navigation's parser, matches nothing, and lands on the '*' → SCREENS.NOT_FOUND catch-all (config.ts:40) — the "Not here" page.

    This also explains why only Windows: Chrome and MacOS: Chrome/Safari are ticked: on a narrow layout the split navigator pushes no central pane, so the Account tab URL stays settings, SETTINGS.ROOT matches, and the flow works.

    What changes do you think we should make in order to solve the problem?

    The FAB is rendered in the navigation tab bar, so it is reachable from every tab and every central-pane screen. The whitelist for this one route should reflect that — widen DYNAMIC_ROUTES.WORKSPACE_CONFIRMATION.entryScreens in src/ROUTES.ts:237 to ['*'], which the validator already supports and which ~10 other dynamic routes already use.

    Add a case to tests/navigation/workspaceConfirmationEntryScreensTest.ts asserting that settings/profile/workspace/confirmation and insights/<dashboardID>/workspace/confirmation resolve to the confirmation screen rather than SCREENS.NOT_FOUND.

    No change is needed to the child routes (currency, plan type, owner selector) — they key off SCREENS.WORKSPACE_CONFIRMATION.DYNAMIC_ROOT and work once the root opens.

    What alternative solutions did you explore? (Optional)

    Two narrower options and why I'd not pick them

    1. Enumerate the missing screens — add SCREENS.INSIGHTS plus every Account-tab central screen (SETTINGS.PROFILE.ROOT, SETTINGS.WALLET.ROOT, SETTINGS.SECURITY, …). This fixes the reported repro but is fragile: any new settings page or new tab silently reintroduces the bug, because the FAB is global and the whitelist is not.

    2. Pass a fixed basePath to createDynamicRoute in NewWorkspaceMenuItem, the way WorkspaceListTable passes ROUTES.WORKSPACES_LIST.route. This works, but it changes what sits behind the RHP and where dismiss returns the user, so it's a UX change rather than a bug fix.

    Not verified in a browser. Browser control was unavailable for this run, so this is static analysis of the navigation code only. Worth confirming the URL on the Account tab really reads settings/profile before implementing.

    Possibly related

    • Teacher Unite - QAB open not here page (Expensify/App#101092) — open, same "Not here from the FAB on Windows Chrome" family, different dynamic route (QAB). May share the entry-screen validation root cause.

    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/102095) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

    view run

  5. MelvinBot
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 23, 2026
  6. melvin-bot
    assigned
    dmkt9
    on Sep 23, 2026

  7. melvin-bot commented on Sep 23, 2026

    @melvin-bot
    melvin-botbot
    on Sep 23, 2026 – with Melvin Bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @dmkt9 (External)

  8. melvin-bot commented on Sep 23, 2026

    @melvin-bot
    melvin-botbot
    on Sep 23, 2026 – with Melvin Bot

    Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

  9. naufalfx805-source commented on Sep 24, 2026

    @naufalfx805-source
    naufalfx805-source
    on Sep 24, 2026 · Hidden as spam

  10. naufalfx805-source commented on Sep 24, 2026

    @naufalfx805-source
    naufalfx805-source
    on Sep 24, 2026 · Hidden as spam

  11. melvin-bot commented on Sep 24, 2026

    @melvin-bot
    melvin-botbot
    on Sep 24, 2026 – with Melvin Bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  12. melvin-bot commented on Sep 28, 2026

    @melvin-bot
    melvin-botbot
    on Sep 28, 2026 – with Melvin Bot

    @dmkt9 Eep! 4 days overdue now. Issues have feelings too...

  13. melvin-bot
    added
    Overdue
    on Sep 28, 2026

  14. dmkt9 commented on Sep 29, 2026

    @dmkt9
    dmkt9
    on Sep 29, 2026
    Contributor

    MelvinBot's proposal looks good to me

    🎀 👀 🎀 C+

  15. 16 remaining items

  16. melvin-bot commented on Oct 12, 2026

    @melvin-bot
    melvin-botbot
    on Oct 12, 2026 – with Melvin Bot

    📣 @dmkt9 We're missing your Upwork ID to automatically send you an offer for the Reviewer role.
    Once you apply to the Upwork job, your Upwork ID will be stored and you will be automatically hired for future jobs!

  17. MuhammadSaadSiddique commented on Oct 12, 2026

    @MuhammadSaadSiddique
    MuhammadSaadSiddique
    on Oct 12, 2026 · Hidden as off-topic
  18. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Oct 12, 2026

  19. melvin-bot commented on Oct 12, 2026

    @melvin-bot
    melvin-botbot
    on Oct 12, 2026 – with Melvin Bot

    📣 @MuhammadSaadSiddique! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

  20. MuhammadSaadSiddique commented on Oct 12, 2026

    @MuhammadSaadSiddique
    MuhammadSaadSiddique
    on Oct 12, 2026 · Hidden as outdated

  21. melvin-bot commented on Oct 12, 2026

    @melvin-bot
    melvin-botbot
    on Oct 12, 2026 – with Melvin Bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  22. melvin-bot
    removed
    ReviewingHas a PR in review
    on Oct 14, 2026
  23. melvin-bot
    changed the title [-][$175] Not here page opens when creating new workspace from FAB on Account and Insights tab[/-] [+][Due for payment 2026-10-21] [$175] Not here page opens when creating new workspace from FAB on Account and Insights tab[/+] on Oct 14, 2026

  24. melvin-bot commented on Oct 14, 2026

    @melvin-bot
    melvin-botbot
    on Oct 14, 2026 – with Melvin Bot

    @dmkt9

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.8-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-10-21. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  25. melvin-bot
    added
    Overdue
    on Oct 14, 2026

  26. dmkt9 commented on Oct 14, 2026

    @dmkt9
    dmkt9
    on Oct 14, 2026
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: N/A

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Test:

    1. Go to staging.new.expensify.com
    2. Create a new Gmail account.
    3. Complete onboarding with Something else intent.
    4. Go to Account.
    5. Open FAB > New workspace.
    6. New workspace confirm page will open.

    Do we agree 👍 or 👎

  27. melvin-bot
    added
    WeeklyKSv2
    and removed
    Overdue
    DailyKSv2
    on Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions