Docs updates for E/A#100278 Document automatic #admins room pinning behavior - #100754
Draft
MelvinBot wants to merge 1 commit into
Draft
Docs updates for E/A#100278 Document automatic #admins room pinning behavior#100754MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
Co-authored-by: Hans Vu <hungvu193@users.noreply.github.com>
Contributor
Author
|
I created this PR from a branch on To take ownership of this branch and push updates yourself, run: Then you can close this PR and open a new one from your fork. If you'd rather just review the content as-is, no action is needed here. |
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up to #100278, which changed when the #admins room is pinned automatically.
Behavior after that PR: only the first workspace a user creates at sign-up gets its #admins room pinned (that room holds the onboarding tasks). Any workspace created afterwards by someone who already owns a paid workspace does not get its #admins room pinned.
Neither behavior was documented anywhere on the help site, so members had no answer to "why is my #admins room pinned?" or "why isn't my new workspace's #admins room pinned?". This PR documents both:
docs/articles/new-expensify/chat/Prioritize-and-Pin-Chats.md— adds a## What chats Expensify pins for you automaticallysection covering the first-workspace rule, the fact that later workspaces are not pinned, and how to unpin.docs/articles/new-expensify/chat/Expensify-Chat-Rooms-for-Admins.md— adds an FAQ entry answering "Why is my #admins room pinned to the top of my inbox?", cross-linked to the pinning article.Both files also get keyword additions so the new content is retrievable.
Terminology was verified against the live web UI before writing: the room is #admins, the chat action buttons are Pin and Unpin, and the sort setting is Priority mode with the options #focus and Most recent. Pinning behavior itself was also confirmed live — the first workspace's #admins room appeared pinned at the top of the Inbox, and a second workspace's #admins room did not.
The changes follow
docs/HELP_AUTHORING_GUIDELINES.md(single#title plus# FAQ, task-based##headings starting with a question word, no###),docs/HELPSITE_NAMING_CONVENTIONS.md(bolded UI labels, exact casing), anddocs/TEMPLATE.md.Fixed Issues
$ Help site follow-up to #100278 (part of #99088)
PROPOSAL: N/A
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Documentation-only change — no app code is touched. Reviewing means confirming the two articles describe the behavior shipped in #100278.
Offline tests
N/A — help site content only.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@hungvu193, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.