Unpin #admin room when creating workspace when user already had paid one by hungvu193 · Pull Request #100278 · Expensify/App

hungvu193 · 2026-09-03T09:43:07Z

Being held for https://github.com/Expensify/Auth/pull/24220

Explanation of Change

Follow up on #99088 which added the logic for CreatePolicy command to unpinned #admin room with user already had paid policy, in this PR, we removes the optimisticData that added isPinned for #admin room.

Fixed Issues

$ Part of #99088
PROPOSAL: N/A

Tests

Same as QA steps

Verify that no errors appear in the JS console

Offline tests

Same as QA steps

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Create a brand new account.
Create a new workspace (you can also create via onboarding) > Verify the #admin room is pinned.
Create another workspace > Verify that the #admin of the second workspace is not pinned.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2026-09-05.at.00.49.48.mov

iOS: mWeb Safari

Screen.Recording.2026-09-05.at.00.50.35.mov

MacOS: Chrome / Safari

unpinned.mov

… policy

codecov · 2026-09-03T09:48:14Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/KYCWall/BaseKYCWall.tsx	`29.50% <ø> (ø)`
src/components/SettlementButton/index.tsx	`74.51% <100.00%> (+0.12%)`	⬆️
src/hooks/useAutoCreateSubmitWorkspace.ts	`94.73% <ø> (ø)`
src/hooks/useAutoCreateTrackWorkspace.ts	`86.48% <ø> (ø)`
src/hooks/useHasOwnedPaidPolicy.ts	`100.00% <100.00%> (ø)`
src/hooks/useOnboardingWorkspaceCreationState.ts	`100.00% <100.00%> (ø)`
...Navigation/AppNavigator/AuthScreensInitHandler.tsx	`88.50% <100.00%> (+0.13%)`	⬆️
src/libs/ReportUtils.ts	`87.26% <100.00%> (ø)`
src/libs/actions/App.ts	`61.70% <ø> (ø)`
src/libs/actions/IOU/PayMoneyRequest.ts	`82.07% <ø> (ø)`
... and 7 more
... and 8 files with indirect coverage changes

melvin-bot · 2026-09-04T17:32:24Z

@rlinoz Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rlinoz · 2026-09-08T17:03:03Z

Looks good, but conflicts @hungvu193

dropped main's rebuilt ncc output for isDeployChecklistLocked and proposalPoliceComment. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

hungvu193 · 2026-09-09T02:57:34Z

Looks good, but conflicts @hungvu193

Done 😄

rlinoz · 2026-09-09T10:46:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MelvinBot · 2026-09-09T10:55:27Z

🤖 Web test steps verification results: ✅ pass

Verified on dev NewDot web (branch fix-99088, HEAD b7a0a7c): a fresh account lands at Home, the first workspace's #admins room is pinned in the LHN, and the second workspace's #admins room is created but not pinned — matching the PR's intended fix.

Step	Status
Brand new account signed in, reaches Home Prestarted session account completed the Join step and landed on the Home tab with onboarding tasks (Create a workspace, Customize accounting categories, etc.) still unchecked, confirming a fresh account.	✅
First workspace created; its #admins room is pinned in the LHN Created the first workspace. In the Inbox LHN, the #admins room for that workspace appears at the top of the list with a visible pin/thumbtack icon on the row.	✅
Second workspace created; its #admins room is NOT pinned in the LHN Created a second workspace. Its #admins room does not appear pre-pinned at the top of the default LHN view (found instead via Search), and once opened its LHN row shows no pin icon and sits in normal chronological position, while the first workspace's #admins row above it still shows its pin icon — confirming only the first room retains the pin and the newly created one is correctly left unpinned.	✅

One caveat: no UI-visible errors, crash screens, or broken states appeared during the flow, but the web agent-device tooling has no console access, so the "no JS console errors" checkbox was not independently captured.

view run · no recording available

OSBotify · 2026-09-09T11:00:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-09-09T11:06:57Z

🚧 rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-09-09T11:11:05Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #100278.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-1870efa-458bc60-489019e7fd4a7a5b19c3e05ba0a3b76c533abf63/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-1870efa-458bc60-778a521fc7e8c3cff1d4d2b89de06c4fc2aae567/index.html

Web 🕸️
https://100278.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-09-09T19:44:57Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.4.75-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-09-09T20:02:25Z

🤖 Yes — help site changes are required. Draft PR: #100754

This PR makes #admins pinning conditional: only the first workspace a user creates at sign-up gets its #admins room pinned, and workspaces created later by someone who already owns a paid workspace do not. Neither half of that rule was documented anywhere under docs/articles, so members had no answer to "why is my #admins room pinned?" or "why isn't my new one?".

Two files updated:

File	Change
`docs/articles/new-expensify/chat/Prioritize-and-Pin-Chats.md`	New `## What chats Expensify pins for you automatically` section — the first-workspace rule, that later workspaces aren't pinned, and how to unpin
`docs/articles/new-expensify/chat/Expensify-Chat-Rooms-for-Admins.md`	New FAQ entry: "Why is my #admins room pinned to the top of my inbox?", cross-linked to the pinning article

How the wording was verified

I drove NewDot on web before writing, so every label in the new copy matches the live UI:

The room is #admins; the chat action buttons are Pin and Unpin.
The sort setting is Priority mode, with options #focus and Most recent.
Behavior confirmed live: after creating a first workspace, its #admins room sat pinned at the top of the Inbox. After creating a second workspace, that workspace's #admins room was not pinned (its Details panel showed an unpinned Pin button).

Applied docs/HELP_AUTHORING_GUIDELINES.md (one # title plus # FAQ, task-based ## headings starting with a question word, no ###), docs/HELPSITE_NAMING_CONVENTIONS.md (bolded UI labels, exact casing, no paraphrasing), and docs/TEMPLATE.md.

One note on the branch: the docs PR is on an Expensify/App branch rather than your fork, since I can't push to hungvu193/App. Instructions for taking it over are in a comment on that PR.

@hungvu193, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

Unpinned #admin room while creating policy with user already had paid…

faf6d22

… policy

melvin-bot Bot assigned hungvu193 Sep 3, 2026

apply the same logic for createWorkspaceFromIOUPayment

df8a818

hungvu193 mentioned this pull request Sep 4, 2026

#admins room is pinned when creating a second/additional workspace in an existing account #99088

Open

hungvu193 marked this pull request as ready for review September 4, 2026 17:31

hungvu193 requested review from a team as code owners September 4, 2026 17:31

melvin-bot Bot requested review from dylanexpensify and rlinoz and removed request for a team September 4, 2026 17:31

fix lint

e66ab62

flaviadefaria requested review from flaviadefaria and removed request for dylanexpensify September 4, 2026 18:03

rlinoz previously approved these changes Sep 8, 2026

View reviewed changes

resolve conflicts

8568330

hungvu193 dismissed rlinoz’s stale review via 8568330 September 9, 2026 02:49

hungvu193 and others added 2 commits September 9, 2026 09:52

fix jest

4f2b9b9

Restore .github/actions/javascript bundles from main

b7a0a7c

dropped main's rebuilt ncc output for isDeployChecklistLocked and proposalPoliceComment. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

hungvu193 requested a review from rlinoz September 9, 2026 02:57

rlinoz approved these changes Sep 9, 2026

View reviewed changes

rlinoz added the Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web label Sep 9, 2026

rlinoz merged commit 1870efa into Expensify:main Sep 9, 2026
34 of 36 checks passed

OSBotify mentioned this pull request Sep 9, 2026

Deploy Checklist: New Expensify 2026-09-09 #100739

Open

75 tasks

MelvinBot mentioned this pull request Sep 9, 2026

Docs updates for E/A#100278 Document automatic #admins room pinning behavior #100754

Draft

40 tasks

Navigation Menu

Uh oh!

Unpin #admin room when creating workspace when user already had paid one - #100278

Unpin #admin room when creating workspace when user already had paid one#100278
rlinoz merged 6 commits into
Expensify:mainfrom
hungvu193:fix-99088

hungvu193 commented Sep 3, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Sep 3, 2026 •

edited by github-actions Bot

Loading

Uh oh!

melvin-bot Bot commented Sep 4, 2026

Uh oh!

rlinoz commented Sep 8, 2026

Uh oh!

hungvu193 commented Sep 9, 2026

Uh oh!

rlinoz commented Sep 9, 2026

Uh oh!

MelvinBot commented Sep 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

OSBotify commented Sep 9, 2026

Uh oh!

github-actions Bot commented Sep 9, 2026

Uh oh!

github-actions Bot commented Sep 9, 2026

Uh oh!

OSBotify commented Sep 9, 2026

Uh oh!

MelvinBot commented Sep 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

hungvu193 commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Sep 3, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Sep 4, 2026

Uh oh!

rlinoz commented Sep 8, 2026

Uh oh!

hungvu193 commented Sep 9, 2026

Uh oh!

rlinoz commented Sep 9, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

OSBotify commented Sep 9, 2026

Uh oh!

github-actions Bot commented Sep 9, 2026

Uh oh!

github-actions Bot commented Sep 9, 2026

Uh oh!

OSBotify commented Sep 9, 2026

Uh oh!

MelvinBot commented Sep 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hungvu193 commented Sep 3, 2026 •

edited

Loading

codecov Bot commented Sep 3, 2026 •

edited by github-actions Bot

Loading

MelvinBot commented Sep 9, 2026 •

edited

Loading