Skip to content

#admins room is pinned when creating a second/additional workspace in an existing account #99088

Description

@melvin-bot

Problem
When creating a new (second/additional) workspace in an existing account, the #admins room for that workspace is pinned in the Inbox. Pinning #admins should only happen for the first workspace created on sign-up, which houses the user's onboarding tasks.

This appears related to — but distinct from — the previously fixed cases where invited/upgraded admins had #admins pinned (Expensify/Expensify#651477).

Expected behavior
Only the first workspace created during sign-up should have its #admins room pinned. Subsequent workspaces created in an existing account should not have their #admins room pinned.

Actual behavior
Creating a second/additional workspace in an existing account pins that workspace's #admins room in the Inbox.

Steps to reproduce

  1. Use an existing account that already has at least one workspace.
  2. Create a new (additional) workspace.
  3. Observe the Inbox — the new workspace's #admins room is pinned.

Confirmed with
Tom Rhys Jones confirmed this shouldn't happen: "it should only be your first workspace on sign-up which houses your onboarding tasks."

Reported in Slack.

Issue OwnerCurrent Issue Owner: @hungvu193

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions