ci: compile TCP benchmark targets on PRs - #595
Merged
Merged
Conversation
Owner
Author
|
@copilot please re-review only; do not make direct code modifications. |
This was referenced Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a PR CI compile-only check for the TCP loopback benchmark targets. The new job configures
ELIO_BUILD_TCP_BENCHMARKS=ONand buildsbench_tcp_elio,bench_tcp_libuv, andbench_tcp_asiowithout running the benchmark loop.The job uses the existing path-filter pattern and exits successfully with an explicit skip message when no TCP benchmark-affecting files changed, so intentional skips are not treated as failures. The contributor guide is updated to include the new TCP benchmark compile check in the PR validation contract.
Type of Change
Related Issues
Closes #580
Related to #581
Changes Made
Core Changes
tcp_benchmarkpaths-filter output for benchmark-affecting changes.tcp-benchmark-compileCI job that installs benchmark compile dependencies, configures a Release examples build with TLS/HTTP disabled, and builds the three TCP benchmark targets.CONTRIBUTING.mdso the documented PR CI contract includes TCP benchmark compile checks.API Changes (if applicable)
None.
Migration Guide (if breaking change)
Not applicable.
Testing
Unit Tests
Integration Tests
Sanitizer Testing
Test Results
Local note:
actionlintis not installed in this environment. Locallibuvdevelopment files are also unavailable, so the local CMake configure did not generatebench_tcp_libuv; the CI job installslibuv1-devbefore building all three targets.Checklist
Code Quality
Documentation
Testing
Compatibility
Performance (if applicable)
Screenshots / Diagrams
Not applicable.
Additional Notes
This intentionally compiles the TCP benchmark targets on PRs but does not run the loopback benchmark. Runtime benchmark execution remains in the dedicated TCP Loopback Benchmark workflow.
Reviewer Guidance
Areas requiring special attention:
Questions for reviewers:
tcp_benchmarkpath filter?