Skip to content

Bound TCP benchmark compile CI job - #617

Merged
Coldwings merged 1 commit into
mainfrom
fix/tcp-benchmark-compile-timeout
Jul 11, 2026
Merged

Bound TCP benchmark compile CI job#617
Coldwings merged 1 commit into
mainfrom
fix/tcp-benchmark-compile-timeout

Conversation

@Coldwings

Copy link
Copy Markdown
Owner

Description

Adds a repository-controlled timeout to the PR-only TCP benchmark compile job so configure/build stalls fail promptly instead of waiting for the GitHub Actions platform default timeout.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance improvement (optimization that improves speed/memory usage)
  • Documentation (changes to documentation, comments, or examples)
  • Refactoring (code changes that neither fix bugs nor add features)
  • Tests (adding or modifying tests)
  • Build/CI (changes to build system, CI configuration, or dependencies)

Related Issues

Closes #612
Related to #595

Changes Made

Core Changes

  • Added timeout-minutes: 15 to the tcp-benchmark-compile job in .github/workflows/ci.yml.
  • Updated CHANGELOG.md for the CI timeout fix.

API Changes (if applicable)

None.

Migration Guide (if breaking change)

Not applicable.

Testing

Unit Tests

  • Added new tests for the changes
  • Updated existing tests if needed
  • All tests pass locally

Integration Tests

  • Tested with existing examples
  • Tested in real-world scenarios (if applicable)

Sanitizer Testing

  • Tested with ASAN (AddressSanitizer)
  • Tested with TSAN (ThreadSanitizer)
  • No new warnings or errors

Test Results

git diff --check
python3 -c "import yaml; yaml.safe_load(open('.github/workflows/ci.yml')); print('ci yaml ok')"
# ci yaml ok

Checklist

Code Quality

  • My code follows the project's code style
  • I have added/updated comments for complex logic
  • I have removed any debug code, TODOs, or commented-out code
  • My changes generate no new warnings

Documentation

  • I have updated documentation (wiki, README, code comments)
  • I have added examples for new features (if applicable)
  • I have updated API documentation (if applicable)

Testing

  • I have added tests that prove my fix is effective or my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested with ASAN and TSAN

Compatibility

  • My changes are backward compatible (or I've documented breaking changes)
  • I have considered the impact on existing users
  • I have updated CHANGELOG.md (if applicable)

Performance (if applicable)

  • I have considered the performance impact
  • I have added benchmarks for performance-critical changes

Screenshots / Diagrams

Not applicable.

Additional Notes

This is a CI-only change; no source build was required locally.

Reviewer Guidance

Areas requiring special attention:

  • Whether 15 minutes is an appropriate upper bound for this compile-only PR job.
  • Whether job-level timeout is preferable to command-level timeout wrappers for this check.

Questions for reviewers:

  • None.

Copilot AI review requested due to automatic review settings July 11, 2026 17:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Coldwings
Coldwings merged commit 992a7d0 into main Jul 11, 2026
10 checks passed
@Coldwings
Coldwings deleted the fix/tcp-benchmark-compile-timeout branch July 11, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] PR TCP benchmark compile job can hang until platform timeout

2 participants