Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ jobs:
runs-on: ubuntu-latest
outputs:
code: ${{ steps.filter.outputs.code }}
tcp_benchmark: ${{ steps.filter.outputs.tcp_benchmark }}
steps:
- name: Checkout repository
uses: actions/checkout@v7
Expand All @@ -34,6 +35,15 @@ jobs:
- 'cmake/**'
- 'tools/**'
- '.github/workflows/**'
tcp_benchmark:
- 'include/**'
- 'examples/bench_tcp_*.cpp'
- 'examples/bench_tcp_common.hpp'
- 'examples/CMakeLists.txt'
- 'CMakeLists.txt'
- '*.cmake'
- 'cmake/**'
- '.github/workflows/**'

build-and-test:
needs: changes
Expand Down Expand Up @@ -248,3 +258,49 @@ jobs:
-DCMAKE_CXX_COMPILER=g++-14 \
-DCMAKE_PREFIX_PATH=${{ github.workspace }}/_install
cmake --build consumer/build --parallel

tcp-benchmark-compile:
needs: changes
runs-on: ubuntu-24.04
name: tcp-benchmark-compile

steps:
- name: Skip TCP benchmark compile
if: needs.changes.outputs.tcp_benchmark != 'true'
run: echo "No TCP benchmark-affecting changes detected; compile check intentionally skipped."

- name: Checkout repository
if: needs.changes.outputs.tcp_benchmark == 'true'
uses: actions/checkout@v7

- name: Install dependencies
if: needs.changes.outputs.tcp_benchmark == 'true'
run: |
sudo apt-get update
sudo apt-get install -y \
cmake \
ninja-build \
liburing-dev \
libuv1-dev \
g++-14

- name: Configure TCP benchmark build
if: needs.changes.outputs.tcp_benchmark == 'true'
run: |
cmake -B build-tcp-benchmark -G Ninja \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_C_COMPILER=gcc-14 \
-DCMAKE_CXX_COMPILER=g++-14 \
-DELIO_BUILD_TESTS=OFF \
-DELIO_BUILD_EXAMPLES=ON \
-DELIO_ENABLE_TLS=OFF \
-DELIO_ENABLE_HTTP=OFF \
-DELIO_ENABLE_HTTP2=OFF \
-DELIO_BUILD_TCP_BENCHMARKS=ON

- name: Build TCP benchmark targets
if: needs.changes.outputs.tcp_benchmark == 'true'
run: |
cmake --build build-tcp-benchmark \
--target bench_tcp_elio bench_tcp_libuv bench_tcp_asio \
--parallel 2
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ perf(runtime): add alignas(64) to worker_thread hot fields
2. **Description**: explain *what* changed and *why*. Reference related issues.
3. **CI must pass**: all required GitHub Actions checks, including matrix
builds (x64/arm64, Release/Debug), ASAN/TSAN, release benchmarks, and the
package-consumer check.
package-consumer and TCP benchmark compile checks.
4. **One logical change per PR**: keep PRs focused. Split unrelated changes.
5. **Breaking changes**: clearly document in the PR description and prefix the
commit with `!` (e.g., `fix(sync)!: make channel non-movable`).
Expand Down