Skip to content

🔧 chore(deps): retain TypeScript compatibility for Astro checks - #83

Draft
zrr1999 wants to merge 3 commits into
codex/website-validation-20261003from
codex/typescript-compatibility-guard
Draft

zrr1999 wants to merge 3 commits into
codex/website-validation-20261003from
codex/typescript-compatibility-guard

Conversation

@zrr1999

@zrr1999 zrr1999 commented Oct 3, 2026 •

Copy link
Copy Markdown
Owner

动机

TypeScript 7.0.2 makes the blog build fail before diagnostics: Astro's language server requires the TypeScript programmatic API that the native compiler does not expose. This reproduces #54 and contradicts the existing TS 6 compatibility requirement in AGENTS.md and the catalog comment.

解决方案

Limit Renovate's TypeScript candidates to <7 until Astro supports the native compiler. TS 6 patch/minor updates remain eligible, and astro check stays in the build.

说明

依赖 #82,基线为 codex/website-validation-20261003。

Validation: reproduced the TS 7 failure after initializing the hosting submodule; the pinned TS 6 root/blog/slides build passes, including 109 indexed blog pages. vp check, all repository hooks, the actual commit hooks, and Renovate 44.46.0's configuration validator pass. The existing #54 is left open for the maintainer's disposition.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
zrr-website-slides eaef933 Commit Preview URL

Branch Preview URL
Oct 10 2026, 03:55 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
zrr-website-blog eaef933 Commit Preview URL

Branch Preview URL
Oct 10 2026, 03:57 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
zrr-website-root eaef933 Commit Preview URL

Branch Preview URL
Oct 10 2026, 03:58 AM

@zrr1999
zrr1999 changed the base branch from main to codex/website-validation-20261003 October 4, 2026 00:33
@zrr1999
zrr1999 added this pull request to stack #86 October 4, 2026 00:38

@morirun morirun left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已审阅 #83 至 952aa2f。

阻塞项:

  • 无。

非阻塞:

  • PR 正文的「动机」「解决方案」用英文写成,与中文模板和其余 stack PR 不一致,建议统一为中文。
  • 该规则生效后,Renovate 通常会关闭不再符合 allowedVersions 的 #54;如需保留跟踪 TS 7 的入口,可另开 issue 关联 withastro/astro#17268,在上游支持后移除此规则。

核对:

  • allowedVersions: "<7" 与 AGENTS.md、pnpm-workspace.yaml catalog 中「TypeScript 钉在 6.x」的约束一致,只限制 typescript 一个包,TS 6 的补丁与次版本更新不受影响。
  • 将 #82、#83 合并到当前 main 后本地 vp run build 通过(含博客 astro check,0 errors)。
  • CI 全绿。

结论:

  • Approve。

@gitar-bot

gitar-bot Bot commented Oct 10, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

🟡 Medium risk · Restricting Renovate to TypeScript versions below 7 could delay compiler fixes and compatibility improvements until Astro supports the native compiler.

Limits Renovate's TypeScript candidates to <7 so the Astro language server keeps working with the TypeScript programmatic API, while TS 6 patch and minor updates remain eligible and astro check stays in the build. No issues found.

Review coverage

📋 Rules No rules evaluated

🧪 Functional validation Not enabled · Set up

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Counting what did not apply, without listing it.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Important

Your trial ends in 3 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

Was this helpful? React with 👍 / 👎 | Gitar

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants