Repository navigation
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
zrr-website-slides | eaef933 | Commit Preview URL Branch Preview URL |
Oct 10 2026, 03:55 AM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
zrr-website-blog | eaef933 | Commit Preview URL Branch Preview URL |
Oct 10 2026, 03:57 AM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
zrr-website-root | eaef933 | Commit Preview URL Branch Preview URL |
Oct 10 2026, 03:58 AM |
morirun
left a comment
There was a problem hiding this comment.
阻塞项:
- 无。
非阻塞:
- PR 正文的「动机」「解决方案」用英文写成,与中文模板和其余 stack PR 不一致,建议统一为中文。
- 该规则生效后,Renovate 通常会关闭不再符合
allowedVersions的 #54;如需保留跟踪 TS 7 的入口,可另开 issue 关联 withastro/astro#17268,在上游支持后移除此规则。
核对:
allowedVersions: "<7"与AGENTS.md、pnpm-workspace.yamlcatalog 中「TypeScript 钉在 6.x」的约束一致,只限制typescript一个包,TS 6 的补丁与次版本更新不受影响。- 将 #82、#83 合并到当前
main后本地vp run build通过(含博客astro check,0 errors)。 - CI 全绿。
结论:
- Approve。
Code Review ✅ Approved🟡 Medium risk · Restricting Renovate to TypeScript versions below 7 could delay compiler fixes and compatibility improvements until Astro supports the native compiler. Limits Renovate's TypeScript candidates to OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 3 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
动机
TypeScript 7.0.2 makes the blog build fail before diagnostics: Astro's language server requires the TypeScript programmatic API that the native compiler does not expose. This reproduces #54 and contradicts the existing TS 6 compatibility requirement in
AGENTS.mdand the catalog comment.解决方案
Limit Renovate's TypeScript candidates to
<7until Astro supports the native compiler. TS 6 patch/minor updates remain eligible, andastro checkstays in the build.说明
依赖 #82,基线为
codex/website-validation-20261003。Validation: reproduced the TS 7 failure after initializing the hosting submodule; the pinned TS 6 root/blog/slides build passes, including 109 indexed blog pages.
vp check, all repository hooks, the actual commit hooks, and Renovate 44.46.0's configuration validator pass. The existing #54 is left open for the maintainer's disposition.