Skip to content

👷 ci: align shared tooling and site validation - #85

Draft
zrr1999 wants to merge 2 commits into
codex/offline-og-fontsfrom
codex/shared-tooling-validation
Draft

zrr1999 wants to merge 2 commits into
codex/offline-og-fontsfrom
codex/shared-tooling-validation

Conversation

@zrr1999

@zrr1999 zrr1999 commented Oct 4, 2026

Copy link
Copy Markdown
Owner

动机

本地 commit hook 仍使用旧入口与旧版本,PR 的 v0.4.0 正文扫描器会把 ~~~ 代码围栏内的 H2 当成真实章节。主页和幻灯片只构建而未运行已有 Astro 静态检查,README 的干净安装命令也与仓库规定的 Vite+ 入口不一致。

解决方案

  • 将 commit hook 与两个 PR actions 统一固定到上游 7d8bcbf6134f62b7c7eaadb763f9a0d434717c44,使用受支持的 zendev-message-check manifest。
  • 复用共享 Markdown 扫描器,保留本仓库的中文 PR 模板契约。
  • 主页、幻灯片的 build 与博客一致,先运行 astro check 再构建。
  • 将 README 的干净安装命令改为 vp install --frozen-lockfile。

说明

依赖 #84(离线 OG 字体);完整顺序为 #82 → #83 → #84 → 本 PR。跨仓库规范迁移与 Spore #15 使用同一个上游提交,各自保留仓库的 PR 模板。

验证:三个应用的 Astro 检查与生产构建通过,vp test run、prek run --all-files、actionlint 和实际 commit hook 通过。包含 ~~~ 围栏内 H2 的正文通过,缺失「解决方案」的正文返回失败。

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
zrr-website-slides 34edac9 Commit Preview URL

Branch Preview URL
Oct 10 2026, 04:02 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
zrr-website-blog 34edac9 Commit Preview URL

Branch Preview URL
Oct 10 2026, 04:04 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
zrr-website-root 34edac9 Commit Preview URL

Branch Preview URL
Oct 10 2026, 04:05 AM

@morirun morirun left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已审阅 #85 至 abe40c5。

阻塞项:

  • 无。

非阻塞:

  • policy-pr.yml 与 prek.toml 固定到 zendev 未打 tag 的提交 7d8bcbf(v0.4.0 之后)。建议在注释中写明对应版本(如 v0.4.0+7d8bcbf),等上游发布包含该修复的 tag 后改回 tag,方便 Renovate 跟踪。
  • 本 PR 未修改 lockfile,但继承自 #84 的 pnpm-lock.yaml 在 rebase 到 main 时需要一并处理。

核对:

  • zendev 7d8bcbf 的 .pre-commit-hooks.yaml 中 zendev-message-check 声明 stages: [commit-msg]。与 main 上 #89 新增的 default_install_hook_types / default_stages 合并时无冲突,且仍在 commit-msg 阶段运行。本地用 prek 验证:不合规的提交信息被拒,🐛 fix(blog): … 通过。
  • 在当前 main 上对 root、slides 运行 astro check:0 errors(root 有 1 条 execCommand 弃用提示);将整个 stack 合并到 main 后 vp run build 三站点通过。
  • README 改为 vp install --frozen-lockfile,与 AGENTS.md「统一用 Vite+」一致。
  • CI 全绿,PR 正文符合模板。

结论:

  • Approve。

@gitar-bot

gitar-bot Bot commented Oct 10, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

🟡 Medium risk · Updating shared PR/message validators and adding Astro checks could reject valid contributions or miss malformed messages, disrupting CI gating.

Aligns the commit hook and both PR actions to a pinned upstream commit using the supported zendev-message-check manifest, reuses the shared Markdown scanner while keeping the Chinese PR template contract, runs astro check before building the homepage and slides, and updates the README install command to vp install --frozen-lockfile. No issues found.

Review coverage

📋 Rules No rules evaluated

🧪 Functional validation Not enabled · Set up

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Counting what did not apply, without listing it.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Important

Your trial ends in 3 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

Was this helpful? React with 👍 / 👎 | Gitar

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants