⚡ Bolt: Resolve N+1 query bottleneck in PoolController.js - #65
Conversation
Extract batched database query outside the Promise.allSettled loop in getPoolData to improve performance when loading keys for many accounts. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Extracted local key fetching out of the
Promise.allSettledloop inPoolController.getPoolDatainto a single, batched database query usingstore.getLocalKeysForAccounts().🎯 Why: Previously, if a user had 20 accounts, the server would execute 20 separate
prisma.key.findManyqueries in parallel inside the map function (an N+1 query pattern). This puts unnecessary load on the database engine and Node memory. Batching reduces this to exactly 1 query.📊 Impact: Reduces database load significantly on initial load for users with multiple accounts. Turns O(N) queries into O(1).
🔬 Measurement: Open the Pool Manager page (
/pool). There should be fewer queries emitted by Prisma, and load time should be stable regardless of the number of accounts.PR created automatically by Jules for task 6233614795514266397 started by @zaydiscold