Skip to content

⚡ Bolt: Batch local keys fetch in PoolController - #66

Closed
zaydiscold wants to merge 1 commit into
masterfrom
bolt-pool-controller-n-1-fix-13531025740241254125
Closed

⚡ Bolt: Batch local keys fetch in PoolController#66
zaydiscold wants to merge 1 commit into
masterfrom
bolt-pool-controller-n-1-fix-13531025740241254125

Conversation

@zaydiscold

Copy link
Copy Markdown
Owner

💡 What: The optimization replaces an N+1 database lookup for getLocalKeys inside PoolController.js's getPoolData accounts loop with a single grouped database query (getAllLocalKeysForUser) before the loop.
🎯 Why: Iterating over accounts and calling store.getLocalKeys inside Promise.allSettled triggers a separate database query per account.
📊 Impact: Reduces O(N) database queries to a single query + O(N) Map lookups, vastly accelerating pool manager page load for users with multiple accounts.
🔬 Measurement: Ensure accurate functionality. Validate pool stats render matching total amount of keys added across multiple accounts. Compare SQLite query logs before and after patch.


PR created automatically by Jules for task 13531025740241254125 started by @zaydiscold

💡 What: Replaced an N+1 database fetch for `getLocalKeys` inside the `getPoolData` loop with a single grouped query `getAllLocalKeysForUser` before the loop, caching the results into a Map.
🎯 Why: Iterating over accounts and calling `store.getLocalKeys` triggered a separate database query per account.
📊 Impact: Reduces O(N) database queries to a single query + O(N) Map lookups, vastly accelerating dashboard load time for users with many OpenRouter accounts.
🔬 Measurement: Verify by executing `GET /api/pool` endpoint directly with several accounts, monitoring logs for db query quantity reduction.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@zaydiscold

Copy link
Copy Markdown
Owner Author

Closing as a duplicate of #65, which is now merged. #65 batches only the accounts being rendered and keeps grouping in the store layer, avoiding unnecessary user-wide key loading.

@zaydiscold zaydiscold closed this Aug 4, 2026
@google-labs-jules

Copy link
Copy Markdown
Contributor

Closing as a duplicate of #65, which is now merged. #65 batches only the accounts being rendered and keeps grouping in the store layer, avoiding unnecessary user-wide key loading.

Understood. Acknowledging that this work is now obsolete as an alternative solution (#65) has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant