Skip to content

Combine canlib and rocketlib - #190

Merged
JasonBrave merged 134 commits into
mainfrom
merge-rocketlib
Oct 10, 2026
Merged

Combine canlib and rocketlib#190
JasonBrave merged 134 commits into
mainfrom
merge-rocketlib

Conversation

@JasonBrave

@JasonBrave JasonBrave commented Sep 30, 2026

Copy link
Copy Markdown
Member

No description provided.

JasonBrave and others added 30 commits November 11, 2023 16:02
@JasonBrave
Initial commit
807edfd
@JasonBrave
Update config file for clang-format 19
bee751c
@JasonBrave
Update config file for clang-format 19 (#15)
10fe45a
@JasonBrave
Migrate PIC18 timer driver and millis from canlib
70d175d
@JasonBrave
Add common return status code enum
be6f855
@JasonBrave
Setup workflow for unit test
cd11de8
@JasonBrave
clang-format low_pass_filter.c
470e828
@JasonBrave
Common code and unit test (#24)
485bcaf
@taisirhassan
Finished porting over low pass filter logic
a4731ca
@taisirhassan
Added comments and made alpha_low a pointer in order to allow multipl…
0a65caa 
…e low pass filters to be initialized
@JasonBrave
Rename error code enum to w_status_t
39975ec
@JasonBrave
Add rocketlib assert function
65fad36
@JasonBrave
Add error code for different error types
3217f7f
@JasonBrave
Error handling and Assert function (#27)
672557f
@JasonBrave
Update clang-format config on 2D array initialize block
b9176a7
@JasonBrave
Update clang-format 19 config (#20)
c8fcae4
@JasonBrave @taisirhassan
Rename error code enum to w_status_t
2dd3d88
@JasonBrave @taisirhassan
Add rocketlib assert function
7faa919
@JasonBrave @taisirhassan
Add error code for different error types
115cb72
@JasonBrave @taisirhassan
Update clang-format config on 2D array initialize block
a31defb
@taisirhassan
Finished porting over low pass filter logic
869f95e
@taisirhassan
Added comments and made alpha_low a pointer in order to allow multipl…
9b79882 
…e low pass filters to be initialized
@taisirhassan
Finished porting over low pass filter logic
d7ea122
@taisirhassan
Added comments and made alpha_low a pointer in order to allow multipl…
0ee279e 
…e low pass filters to be initialized
@JasonBrave @taisirhassan
Add rocketlib assert function
decca85
@taisirhassan
Merge branch 'master' into low_pass_filter
d6761fd
@taisirhassan
fixed some issues with redefining function twice
fe96772
@taisirhassan
added some comments and also fixed some errors with unit tests workfl…
355a473 
…ow failing
@taisirhassan
Refactored low pass filter functions to improve error handling and re…
f405472 
…turn types
@taisirhassan
Fixed errors with sphinx not compiling properly
32b3aeb
SAT-oO
SAT-oO previously approved these changes Oct 4, 2026
View reviewed changes

@SAT-oO SAT-oO left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is prob another pr I reviewed in my dreams but forgot to click approve

booo for not being barr compliant (jkjk
thanks Jason merging them both; appreciate the test coverage

Shiming-He
Shiming-He previously approved these changes Oct 5, 2026
View reviewed changes

@Shiming-He Shiming-He left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but this is just a thought

Comment thread common/common.h Resolved
Shiming-He
Shiming-He reviewed Oct 6, 2026
View reviewed changes

@Shiming-He Shiming-He left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually thoughts. Should we not have a general include file like canlib.h for what remains for canlib, as I don't think it's that useful that now each module must include all of the files seperately

sky46
sky46 reviewed Oct 6, 2026
View reviewed changes
Comment thread can_message/packet_format.h Resolved
sky46
sky46 reviewed Oct 6, 2026
View reviewed changes
Comment thread can_message/msg_canards.c Resolved
sky46
sky46 reviewed Oct 6, 2026
View reviewed changes
Comment thread common/common.h Resolved
@sky46

sky46 commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

I think we should have a separate include/ directory for all the includes

sky46
sky46 requested changes Oct 6, 2026
View reviewed changes

@sky46 sky46 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I can help make these changes later this week if you don't need this to be merged immediately

@JasonBrave

JasonBrave commented Oct 6, 2026

Copy link
Copy Markdown
Member Author

this is prob another pr I reviewed in my dreams but forgot to click approve @SAT-oO

There was a old PR for demo at elec meeting, this is the real deal

@JasonBrave
JasonBrave dismissed stale reviews from Shiming-He and SAT-oO via 0073c94 October 7, 2026 00:44
@JasonBrave

JasonBrave commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

I think we should have a separate include/ directory for all the includes @sky46

With the current layout it's much easier to update source and header file at same time, this directory layout is used in most open source C library. And the current directory layout shouldn't really affect how you use the library in either cubeide or platform io

Shiming-He
Shiming-He approved these changes Oct 7, 2026
View reviewed changes

@Shiming-He Shiming-He left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

dare-eee-enn
dare-eee-enn approved these changes Oct 9, 2026
View reviewed changes

@dare-eee-enn dare-eee-enn left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JasonBrave
JasonBrave merged commit be2812f into main Oct 10, 2026
5 checks passed
@JasonBrave
JasonBrave deleted the merge-rocketlib branch October 10, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sky46 sky46 sky46 approved these changes
@Shiming-He Shiming-He Shiming-He approved these changes
@dare-eee-enn dare-eee-enn dare-eee-enn approved these changes
@ChristineS112 ChristineS112 ChristineS112 approved these changes
@Shiman-Zhu Shiman-Zhu Awaiting requested review from Shiman-Zhu
@SAT-oO SAT-oO Awaiting requested review from SAT-oO
@Hexamech Hexamech Awaiting requested review from Hexamech

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@JasonBrave @sky46 @SAT-oO @Shiming-He @dare-eee-enn @ChristineS112 @taisirhassan @joelleg123 @x-ximena @lukeqin-s