Skip to content

fix(kit): keep handle ids unique after the registry is cleared #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webfansplz merged 1 commit into from
Oct 18, 2026
Merged

fix(kit): keep handle ids unique after the registry is cleared #1161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/kit/src/codec/handles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export class ValueHandleRegistry {
this.handleToScope.clear()
this.scopeToHandles.clear()
this.objectToHandle = new WeakMap()
this.seed = 0
// Keep seed: a stale handle from before clear() must miss, not resolve to a new object.
}

private evictOverflow(): void {
Expand Down
11 changes: 11 additions & 0 deletions tests/unit/codec/handles.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,15 @@ describe('ValueHandleRegistry', () => {
registry.releaseScope('state:component-a')
expect(registry.get(childHandle)).toBeUndefined()
})

it('does not reuse handle ids after clear', () => {
const registry = new ValueHandleRegistry()
const stale = registry.getOrCreate({ old: true })
registry.clear()
const fresh = { fresh: true }
const handle = registry.getOrCreate(fresh)
expect(handle).not.toBe(stale)
expect(registry.get(stale)).toBeUndefined()
expect(registry.get(handle)).toBe(fresh)
})
})
Loading