Repository navigation
fix(kit): keep handle ids unique after the registry is cleared - #1161
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for vue-devtools-docs canceled.
|
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`ValueHandleRegistry.clear()` reset `seed` to 0. The runtime clears the timeline handle registry when the last DevTools client disconnects, so after a reconnect new values were handed the same ids (`value:0`, `value:1`, …) as values from the previous session. A client still holding an old handle would then read or edit an unrelated object instead of getting a missing-handle result.
`clear()` now keeps `seed` increasing, so a stale handle simply misses.
Added a regression test in `tests/unit/codec/handles.test.ts`; it fails without the fix. `pnpm vitest run tests/unit tests/integration` passes (364 tests).
🤖 Generated with Claude Code