Skip to content

fix(client): improve state section toggle a11y #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webfansplz merged 2 commits into from
Oct 15, 2026
Merged

fix(client): improve state section toggle a11y #1156

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05c9374
fix(client): make state section headings keyboard accessible
Xinglan233 Oct 14, 2026
0e71ff8
chore: remove test
webfansplz Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/client/src/components/common/InspectorState.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,10 @@ function includesFilter(value: string | undefined, filter: string): boolean {

<div v-else-if="!emptyState">
<section v-for="section in filteredStateSections" :key="section.id">
<div
class="flex cursor-pointer items-center hover:bg-active"
<button
class="w-full flex cursor-pointer items-center border-0 bg-transparent p-0 text-left color-inherit hover:bg-active"
type="button"
:aria-expanded="isStateSectionExpanded(section.id)"
@click="toggleStateSection(section.id)"
>
<span
Expand All @@ -245,7 +247,7 @@ function includesFilter(value: string | undefined, filter: string): boolean {
{{ section.label }}
</span>
<span v-if="section.partial" class="ml-2 color-muted text-11px">partial</span>
</div>
</button>

<div v-if="isStateSectionExpanded(section.id)">
<StateEntryRow
Expand Down
Loading