Skip to content

fix(client): improve state section toggle a11y - #1156

Merged
webfansplz merged 2 commits into
vuejs:mainfrom
Xinglan233:fix/state-section-keyboard-accessibility
Oct 15, 2026
Merged

webfansplz merged 2 commits into
vuejs:mainfrom
Xinglan233:fix/state-section-keyboard-accessibility

Conversation

@Xinglan233

Copy link
Copy Markdown
Contributor

Summary

The setup, props, and data section headings in the Components inspector can be clicked to expand or collapse, but keyboard users cannot reach them with Tab. They are rendered as divs, so their expanded state is also missing from the accessibility tree.

  • Render section headings as native buttons so they support Tab, Enter, and Space.
  • Expose each section’s expanded state with aria-expanded.
  • Preserve the existing layout and collapse behavior, with a visible keyboard focus indicator.
  • Add regression tests for section toggling and state handling.

This change is limited to state section headings and does not overlap with the AppList changes in #1152 or the Render Code changes in #1146.

Relates to #885.

Validation

  • Regression tests fail on the original code and pass with the fix; pnpm test passes (61 files, 360 tests).
  • pnpm check, pnpm typecheck, pnpm lint, pnpm format:check, pnpm build, and git diff --check pass.
  • Verified in Chrome on macOS: Tab/Shift+Tab, Enter/Space, mouse toggling, visible focus in both themes, state editing, component switching, and Pinia sections.
  • Screen-reader testing has not been performed.

Copilot AI balanced review requested due to automatic review settings October 14, 2026 10:40
@netlify

netlify Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit 0e71ff8
🔍 Latest deploy log https://app.netlify.com/projects/vue-devtools-docs/deploys/6ad030a9dc7d30f39ae78d00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Xinglan233
Xinglan233 marked this pull request as ready for review October 14, 2026 10:48
@Xinglan233 Xinglan233 mentioned this pull request Oct 14, 2026
3 tasks
Copilot AI balanced review requested due to automatic review settings October 15, 2026 01:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@pkg-pr-new

pkg-pr-new Bot commented Oct 15, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@vue/devtools-api@1156
npm i https://pkg.pr.new/@vue/devtools-kit@1156
npm i https://pkg.pr.new/vite-plugin-vue-devtools@1156

commit: 0e71ff8

@webfansplz webfansplz changed the title fix(client): make state section headings keyboard accessible fix(client): improve state section toggle a11y Oct 15, 2026
@webfansplz
webfansplz merged commit 78effda into vuejs:main Oct 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants