Repository navigation
fix(reset): leave audio, object, embed and image inputs to the browser - #131
Conversation
The first rule of the reset unsets every property and reverts display alone, so <audio controls> lost the size the browser stylesheet gives it: 0x0 in Chrome (280x0 under an author width), 44px wide in Safari 17.6. The New CSS Reset has excluded audio since 1.7.3, and this copy predates that version. object, embed and input[type=image] lost the size set by their width and height attributes, which the unset overrides, the reason img, iframe, canvas and video were already excluded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
WalkthroughThe universal reset selector now excludes ChangesReset exclusions
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly summarizes the main reset change by naming the affected elements and stating that the browser should retain control over them. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit reads the reset with care,
Four more tags keep their sizing there.
Audio keeps its controls in view,
Image inputs keep their cursor too.
The changelog marks the work complete,
I twitch my nose and thump my feet!
Comment @coderabbitai help to get the list of available commands.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔇 Additional comments: 3
src/reset.scss: 2
7-8: LGTM!
18-21: LGTM!CHANGELOG.md-9-9: 1
9-9: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
⚠️ Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.Complete the opening sentence.
The first bullet is a sentence fragment. Add a subject and verb so readers can parse the reported behavior clearly.
Suggested correction
-* An `<audio controls>` laid out with no size, so its controls were in the DOM and nothing showed. +* An `<audio controls>` element had no size, so its controls remained in the DOM but were not visible.
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
fd2a45c5-2c35-411f-b299-aa381de306b8
📒 Files selected for processing: 2
CHANGELOG.mdsrc/reset.scss
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
1 participant
What
The first rule of the reset (
all: unset; display: revert) now leavesaudio,object,embedandinput[type='image']alone, next tovideo.Why
<audio controls>takes its size from the browser stylesheet, which the reset removed. Chrome laid it out 0x0 (280x0 under an author width), and Safari 17.6 shrank it to 44px wide. The New CSS Reset has excludedaudiosince 1.7.3, and our copy predates that version.object,embedand image inputs lost the size set by theirwidth/heightattributes.Verification
Measured in Chrome 155 and Safari 17.6 (light and dark themes): audio 280x54 / 250x31, audio without
controlsstill hidden, attribute-sized object/embed/image input back to 400x200. Firefox not measured.dist/changes only in the reset selector.For consumers
Apps that added
all: revertto their<audio>elements as a workaround can drop it once they are on this release.🤖 Generated with Claude Code
Summary by CodeRabbit