Repository navigation
Release of v0.1.32 - #132
Merged
Merged
Conversation
The first rule of the reset unsets every property and reverts display alone, so <audio controls> lost the size the browser stylesheet gives it: 0x0 in Chrome (280x0 under an author width), 44px wide in Safari 17.6. The New CSS Reset has excluded audio since 1.7.3, and this copy predates that version. object, embed and input[type=image] lost the size set by their width and height attributes, which the unset overrides, the reason img, iframe, canvas and video were already excluded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fix(reset): leave audio, object, embed and image inputs to the browser
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This release brings
developintomainfor v0.1.32. It is a fix release with a single change, the reset fix of #131.CHANGELOG.mddescribes it under 0.1.32, with its mechanism and its consequence.Fixed
<audio controls>rendered with no size: 0x0 in Chrome (280x0 under an author width), and 44px wide in Safari 17.6. The first rule of the reset now leavesaudioalone, as The New CSS Reset has done since 1.7.3. An<audio>withoutcontrolsstays hidden, and the controls follow thecolor-schemeof the theme.<object>,<embed>and<input type="image">ignored theirwidthandheightattributes. The reset now leaves them alone too, likeimg,iframe,canvasandvideo.What consumers have to know
all: revertto their<audio>elements as a workaround can drop it.object,embedor image input that carrieswidthandheightattributes now takes that size, where it used to take its intrinsic size. Sizes set in CSS still win, as before.dist/changes only in the selector of the first reset rule (+37 bytes inreset.css,base.cssandvolver.css).design-tokens.jsonand theexportsmap do not change, and no token is renamed or removed.Verification
stylelint,lint,build,stylelint:distandcheck:colorspass.dist/diff. Read against a clean build of the previousdevelop: the selector is the only change.This release publishes 0.1.32 under
latest.🤖 Generated with Claude Code