Repository navigation
ref: make EvidenceCreationCb satisfy trait FnOnce - #44
Merged
Merged
Conversation
Author
|
Hi @thomas-fossati please review this PR. |
Contributor
|
Fixes #42 |
thomas-fossati
approved these changes
Aug 12, 2026
thomas-fossati
left a comment
thomas-fossati
left a comment
Contributor
There was a problem hiding this comment.
LGTM (with minor rustdoc suggestion inline), thanks!
function type fn() is too limiting for capturing variables in closures. This capability is required with rust-regl where an attester must be called to generate evidence. Use trait FnOnce to define evidence callback functions. Signed-off-by: Atul Kumar <Atul.Kumar@fujitsu.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
function type fn() is too limiting for capturing variables in closures. This capability is required with rust-regl where an attester must be called to generate evidence.
Use trait FnOnce to define evidence callback functions.