Repository navigation
fix: handle discovery URL correctly - #41
Conversation
|
@thomas-fossati can you have a look at it? |
thomas-fossati
left a comment
thomas-fossati
left a comment
There was a problem hiding this comment.
LGTM, thanks! I have left my usual handful of comments inlnie.
Signed-off-by: Dhanus M Lal <Dhanus.MLal@fujitsu.com>
Signed-off-by: Dhanus M Lal <Dhanus.MLal@fujitsu.com>
Handle discovery base urls as url::Url instead of String. Signed-off-by: Dhanus M Lal <Dhanus.MLal@fujitsu.com>
Signed-off-by: Dhanus M Lal <Dhanus.MLal@fujitsu.com>
Cargo.lock should be tracked by VCS (https://blog.rust-lang.org/2023/08/29/committing-lockfiles/) Removed Cargo.lock from .gitignore Signed-off-by: Dhanus M Lal <Dhanus.MLal@fujitsu.com>
|
🚢 it, thanks! |
Hi @thomas-fossati since I cant add approvers, please add 1 more approver( as this blocks merging) so that we can merge this and raise other PRs which are dependent on this one. Thanks |
Sure, added @paulhowardarm as reviewer. (Let me fiddle with the repo settings so that you can add reviewers in the future.) |
Shefali, I just added you and @DhanusML. Let me know if anyone else needs write access. |
paulhowardarm
left a comment
paulhowardarm
left a comment
There was a problem hiding this comment.
Looks like a worthy improvement, and looks good to me. Many thanks for the contribution.
5 participants
context: building a DiscoveryBuilder with_base_url with a trailing / (empty path) resulted in error while building the discovery URL, by appending "/.well-known/xxx" with the base URL string.