Skip to content

enhancement: use a library to handle URLs #40

Closed
#41
Closed
enhancement: use a library to handle URLs#40
#41

Description

@Harshita-Badiyasar
Harshita-Badiyasar
opened on Jul 9, 2026

While constructing the full URL from base URL using with_base_url() in DiscoveryBuilder the trailing slash from the base URL is not removed.
There could be more such unhandled scenarios when we are doing this on our own.
It would be better to make use of a URL utility library such as url.

Activity

  1. shefali-kamal commented on Jul 13, 2026

    @shefali-kamal
    shefali-kamal
    on Jul 13, 2026

    The fix will be pushed soon.

  2. shefali-kamal commented on Jul 24, 2026

    @shefali-kamal
    shefali-kamal
    on Jul 24, 2026

    This will be fixed by #41

  3. thomas-fossati
    closed this as completedin #41on Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions