Repository navigation
Conversation
4 tasks
|
Just squash all the commits and edit the commit message to explain the move.. Once that is complete, I will approve the PR |
Extract the legacy JSON and v2 CBOR/COSE evidence-token libraries from veraison/ratsd at commit 7ab53a031ba9a376a69b86397c5ed60954d1894d so token producers and consumers can depend on the libraries independently of the RATSD daemon. Use github.com/veraison/ratsd-token for the legacy module and github.com/veraison/ratsd-token/v2 for the CBOR/COSE module. Bring over their tests, CDDL specification, and token example, and document the new import paths and how to test both modules. Add CI with a similar build/test, minimum-coverage, and code-quality check structure to veraison/psatoken and veraison/ccatoken. Adapt it to both Go modules, with builds and race tests on Ubuntu and macOS. Use go vet and gofmt for code-quality checks, and enforce per-module coverage thresholds on Ubuntu. Signed-off-by: Ian Chin Wang <ian.chin.wang@oracle.com>
Collaborator
Author
Thanks for the suggestion. The reason why I separated the CI commit out from the initial commit was because the pipelines were not part of the original ratsd repo. I'm OK with brining in the CI from the very beginning, and acknowledge the CI pipelines are from other token repos of Veraison, psatoken and cctoken. The squash is now completed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
veraison/ratsdinto this repository, with standalone Go module paths.Verification
go test ./...in the repository root andv2/go test -race -cover ./...in both modulesgo vet ./...in both modules