Repository navigation
Use standalone ratsd-token modules - #105
Merged
Merged
Conversation
Switch legacy and v2 token imports to github.com/veraison/ratsd-token and pin both modules to commit 93500f814d56. Remove the duplicate local modules and replacements, refresh checksums, and document the standalone dependencies. Signed-off-by: Ian Chin Wang <ian.chin.wang@oracle.com>
yogeshbdeshpande
approved these changes
Oct 20, 2026
yogeshbdeshpande
left a comment
yogeshbdeshpande
left a comment
Contributor
There was a problem hiding this comment.
Left one minor comment, but LGTM!
Signed-off-by: Ian Chin Wang <ian.chin.wang@oracle.com> Co-authored-by: Yogesh Deshpande <yogesh.deshpande@arm.com>
Collaborator
Author
Thanks @yogeshbdeshpande for pointing out to need to explicitly say they are "attestation" tokens. As veraison/ratsd-token#1 contains the code factored out from with this PR, it might be worth to review it together as well. |
THS-on
approved these changes
Oct 21, 2026
THS-on
left a comment
THS-on
left a comment
Member
There was a problem hiding this comment.
Thanks for factoring this out!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RATSD currently imports its bundled legacy and v2 token libraries through local
module replacements. Switch the API and its tests to
github.com/veraison/ratsd-tokenand
github.com/veraison/ratsd-token/v2, pinning both modules to standalone commit93500f814d56, which matches the existing implementations.Remove the duplicate in-repository modules and local replacements, record the
standalone module checksums, and document the external dependencies in the README.
Validation:
go test -mod=readonly ./apigo test -mod=readonly -race ./...go build -mod=readonly ./...git diff --check