Skip to content

Fix a bug where rdcards() doesn't work if you follow includes and return type dict #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twmacro merged 6 commits into from
Jul 22, 2026
Merged

Fix a bug where rdcards() doesn't work if you follow includes and return type dict #53

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4da3348
includes should be read in as type array, then after the recursion it…
Jul 21, 2026
d99d31e
ensure keys are int (cards can only have int id anyway)
Jul 21, 2026
03f2da2
try to fix an issue with tests not retaining the GRID card
Jul 21, 2026
7043719
correct a typo, array should be a string
Jul 21, 2026
c56dc0d
test if this fixes the test issues
Jul 21, 2026
efe9487
It did not. It appears to be a python version issue.
Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pyyeti/nastran/bulk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,10 +777,12 @@ def rdcards(
for symbol in include_symbols:
if not len(symbol) > 2:
raise ValueError(f"Symbols must have a length >1, got {symbol}")

kwargsReturnType = "list" if return_var == "list" else "array"
kwargs = { # save args for use in _rdinclude
"name": name,
"blank": blank,
"return_var": return_var,
"return_var": kwargsReturnType,
"dtype": dtype,
"no_data_return": (), # return value from _rdinclude must be iterable (not None)
"regex": regex,
Expand Down Expand Up @@ -825,7 +827,7 @@ def rdcards(
for val in vals:
cur = len(val)
mxlen = max(mxlen, cur)
key = val[0] # before it gets turned into dtype
key = int(val[0]) # before it gets turned into dtype
val = np.array(val).astype(dtype)
if todict:
Vals[key] = val
Expand Down
Loading