Fix a bug where rdcards() doesn't work if you follow includes and return type dict - #53
Merged
twmacro merged 6 commits intoJul 22, 2026
Merged
Conversation
added 4 commits
July 21, 2026 14:18
… will be converted to list or dict below
rjyunis
marked this pull request as draft
July 21, 2026 21:45
Contributor
Author
|
I'm marking this as ready to review, since the failing tests seem to be based on differences between python versions rather than code correctness. The cases fail even when I revert my changes. |
rjyunis
marked this pull request as ready for review
July 21, 2026 22:13
Owner
|
Thanks for the update, @rjyunis! I'm not sure why some tests aren't passing, but it seems unrelated to these updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good afternoon,
This corrects a small bug where
rdcards()doesn't work when you request a return type of dict AND follow includes. When_rdinclude()returns (line 815), the values would already be a dictionary, so theforloop (line 826)valis a key (an int) instead of a list. This meanslen(val)on the following line doesn't work. If you just pass "array" to_rdinclude()instead, it will be read in correctly and converted later in the function.I also cast key to
int. Sometimes the keys are floats and I'm not sure why.