fix(rules): CSKILL keyword FPs and CSDK bypassPermissions gap - #157
Merged
Merged
Conversation
Two confirmed bugs from outreach feedback (August-September batch). Bug 1 — CSKILL-080/081 keyword FPs: matched raw substrings with no word boundaries or operational context, firing on documentation mentions rather than actual behavior. New sentence-scoped word-boundary predicate (schema 17 -> 18) used only by these two rules; CSKILL-082..087 keep the old raw-substring matching, not implicated in any confirmed FP. Bug 2 — retargeted after verification against the Agent SDK's own docs: allowed_tools only auto-approves, it does not restrict, so bypassPermissions + a narrow allow-list is the worst case, not a mitigated one. Retargeted onto the two mechanisms that genuinely restrict: - CSDK-202: new per-construction-site predicate correlating permission_mode + disallowed_tools at the same site - New CSDK-206 (medium/0.6): the complementary case - CSDK-103/120: added a tools-scope co-check on AgentDefinition.tools Mirrored byte-for-byte from the engine fixture.
ivanpaghubasan
requested review from
ericksondelacruz,
jhumel-code and
sairenchristianbuerano
September 22, 2026 05:49
sairenchristianbuerano
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two confirmed bugs from outreach feedback (August-September batch).
Bug 1 — CSKILL-080/081 keyword FPs: matched raw substrings with no word boundaries or operational context, firing on documentation mentions rather than actual behavior. New sentence-scoped word-boundary predicate (schema 17 -> 18) used only by these two rules; CSKILL-082..087 keep the old raw-substring matching, not implicated in any confirmed FP.
Bug 2 — retargeted after verification against the Agent SDK's own docs: allowed_tools only auto-approves, it does not restrict, so bypassPermissions + a narrow allow-list is the worst case, not a mitigated one. Retargeted onto the two mechanisms that genuinely restrict:
Mirrored byte-for-byte from the engine fixture.