fix(rules): CSKILL pattern-blindness on CSKILL-050 and CSKILL-082 - #150
Merged
sairenchristianbuerano merged 1 commit intoSep 21, 2026
Merged
Conversation
Both rules matched on tool name only, never the grant Pattern, so a narrowly-scoped grant like Bash(git status:*) fired identically to unrestricted Bash(*). Switched to skill_allows_unrestricted_tool, which respects Claude Code's real per-tool permission semantics — Bash/PowerShell/WebFetch/Edit have genuine pattern restrictions, Write/NotebookEdit path rules are accepted but never consulted so those remain always-unrestricted. Old skill_allows_tool key retained (now documented as pattern-blind) per the predicate-renaming discipline. Schema version bumped 16 -> 17. Mirrored byte-for-byte from the engine fixture.
ivanpaghubasan
requested review from
ericksondelacruz,
jhumel-code and
sairenchristianbuerano
September 18, 2026 12:52
sairenchristianbuerano
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both rules matched on tool name only, never the grant Pattern, so a narrowly-scoped grant like Bash(git status:) fired identically to unrestricted Bash(). Switched to skill_allows_unrestricted_tool, which respects Claude Code's real per-tool permission semantics — Bash/PowerShell/WebFetch/Edit have genuine pattern restrictions, Write/NotebookEdit path rules are accepted but never consulted so those remain always-unrestricted.
Old skill_allows_tool key retained (now documented as pattern-blind) per the predicate-renaming discipline. Schema version bumped 16 -> 17.
Mirrored byte-for-byte from the engine fixture.