fix(google_adk): move the four tool-scoped rules into the 0NN block - #219
Merged
Merged
Conversation
ADK-114, ADK-115, ADK-116 and ADK-117 shipped with scope: tool while sitting in the 1NN block, which the README documents as agent or subagent scope. Every other ADK rule obeys the split: 001-016 are tool scope, 101-112 are agent scope. @jhumel-code asked for this on the ADK-117 pull request before it landed and named ADK-014 as the replacement; the merge went in ahead of the change. IDs are permanent once anything external references them, so this closes the gap while it is still free. ADK-117 -> ADK-014 TypeScript FunctionTool writes to the filesystem ADK-114 -> ADK-017 TypeScript FunctionTool HTTP call has no timeout ADK-115 -> ADK-018 FunctionTool description is a placeholder ADK-116 -> ADK-019 FunctionTool description is too short 014, 017, 018 and 019 were the free ids in the 0NN block. Rule text, severity, confidence and match expressions are unchanged. Also extends the README file map for google_adk to name the new rules, matching how the claude_sdk lines already name CSDK-012. ADK-008 remains agent scope in the 0NN block. That one predates this and the README documents it explicitly, so it is left alone.
trustabl
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These four shipped with
scope: toolwhile sitting in the1NNblock, which the README documents as agent or subagent scope. Every other ADK rule obeys the split — 001–016 are tool scope, 101–112 are agent scope.@jhumel-code asked for exactly this on trustabl/agent-reliability-rules#96 before it landed, and named
ADK-014as the replacement:The merge went in ahead of the change. This closes it while the ids are still free.
ADK-117ADK-014ADK-114ADK-017ADK-115ADK-018ADK-116ADK-019014,017,018and019were the free ids in the0NNblock. Rule text, severity, confidence and match expressions are unchanged — only the id.Verified
ADK-008is agent scope in the0NNblock, predates this, and the README names it explicitly — left alonetrustabl rules validate: 276 rules valid under schema 17go test ./internal/rules/passes; all 10 renumbered cases execute and pass under the new idscheck-rules-sync.sh: in sync, 109 files comparedMerge back to back with trustabl/agent-reliability-rules#154. Either half alone renames a rule on one side only and turns
rules-syncred.