Conversation
Engine half of a coordinated pair with trustabl/agent-reliability-rules#105, on a branch of the same name so the rules-sync job resolves the matching pack rather than main. Neither half should merge alone — check-rules-sync.sh fails if they do. Mirrors crewai/tool_definition.yaml into testdata/rules-fixture and adds cases to policyRuleCases, as TestPolicyRules_AllRulesCovered requires. Three cases: the generic name, the verb-object remediation, and process_invoice_batch — a name that merely contains a listed word and must stay silent. The third pins that name_in matches the whole name rather than a substring, which is the plausible regression and the one that would otherwise flood well-named tools with findings.
|
Thanks @bradAGI. The mirror is exact: comparing the added block here against trustabl/agent-reliability-rules#105 line for line, the two are identical, which is what The three cases are right, and the third is the one worth having. I have left a change request on the rules half about CrewAI's positional decorator name, since Happy to take it once the rules half is settled and mirrored back here. |
What the pair adds
Ports the ambiguous-name check to this pack. CSDK-007, OAI-007, ADK-007, and MCP-003 all ship it; the newer packs had none. Same
name_inlist as CSDK-007.What this PR does
crewai/tool_definition.yamlintotestdata/rules-fixture/.policyRuleCases, asTestPolicyRules_AllRulesCoveredrequires.def process(...)def summarize_invoice(...)def process_invoice_batch(...)Three cases rather than two. The third is the one worth having:
process_invoice_batchmerely contains a listed word. It pins thatname_inmatches the whole name rather than a substring — the plausible regression, and the one that would otherwise flood well-named tools with findings across every pack using this list at once.Verification