Skip to content

Respect a caller-provided applicationProtocols in makeTLSBootstrap #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
o-nnerb wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Respect a caller-provided applicationProtocols in makeTLSBootstrap #930

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bd950d
Only override applicationProtocols in makeTLSBootstrap when unset
o-nnerb Sep 9, 2026
6a5f8cc
Merge branch 'main' into claude/applicationprotocols-override-fix-0e8cc0
o-nnerb Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions Sources/AsyncHTTPClient/ConnectionPool/HTTPConnectionPool+Factory.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,15 +574,17 @@ extension HTTPConnectionPool.ConnectionFactory {
}

var tlsConfig = self.tlsConfiguration
switch self.clientConfiguration.httpVersion.configuration {
case .automatic:
// since we can support h2, we need to advertise this in alpn
// "ProtocolNameList" contains the list of protocols advertised by the
// client, in descending order of preference.
// https://datatracker.ietf.org/doc/html/rfc7301#section-3.1
tlsConfig.applicationProtocols = ["h2", "http/1.1"]
case .http1Only:
tlsConfig.applicationProtocols = ["http/1.1"]
if tlsConfig.applicationProtocols.isEmpty {
switch self.clientConfiguration.httpVersion.configuration {
case .automatic:
// since we can support h2, we need to advertise this in alpn
// "ProtocolNameList" contains the list of protocols advertised by the
// client, in descending order of preference.
// https://datatracker.ietf.org/doc/html/rfc7301#section-3.1
tlsConfig.applicationProtocols = ["h2", "http/1.1"]
case .http1Only:
tlsConfig.applicationProtocols = ["http/1.1"]
}
}

#if canImport(Network)
Expand Down