Repository navigation
Conversation
Previously the ALPN protocol list was unconditionally overwritten based on the configured HTTP version, discarding any applicationProtocols the caller had already set on their own TLSConfiguration. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
makeTLSBootstrapalways overwritestlsConfig.applicationProtocolsbased on the configuredhttpVersion, even when the caller already set their own ALPN protocol list on theTLSConfigurationthey passed in viaHTTPClientConfiguration.tlsConfiguration. That list was silently discarded.This only sets
applicationProtocolsfromhttpVersionwhen the caller left it empty, so a custom ALPN list set on theTLSConfigurationitself is respected.