Skip to content

fix: resolve node components eagerly in dev to avoid 500 errors on in-flight reloads (#17554) #17593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
praveen-kumary wants to merge 1 commit into from
Closed

fix: resolve node components eagerly in dev to avoid 500 errors on in-flight reloads (#17554) #17593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dev-manifest-component-eager.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: start loading node components eagerly in dev to avoid 500 errors on in-flight requests during server module reloads
24 changes: 14 additions & 10 deletions packages/kit/src/exports/vite/dev/generate_manifest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,18 +95,22 @@ export function generate_manifest(
const module_nodes = [];

if (node.component) {
result.component = async () => {
const { module_node, module } = await resolve(
vite,
vite_dev_server,
runner,
/** @type {string} */ (node.component)
);

// Start loading the component immediately so it is evaluated in the same module
// generation as root.svelte and svelte/internal/server, rather than waiting until
// after async load() functions finish when in-flight server edits may have triggered a reload (#17554)
const component_promise = resolve(
vite,
vite_dev_server,
runner,
/** @type {string} */ (node.component)
).then(({ module_node, module }) => {
Comment on lines +101 to +106

@vercel vercel Bot Nov 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pages with ssr = false now evaluate their components on the server, causing valid browser-only module code to trigger server errors and Vite error overlays.

Fix on Vercel

module_nodes.push(module_node);

return module.default;
};
});

component_promise.catch(() => {});

result.component = () => component_promise;
}

if (node.universal) {
Expand Down
Loading