Repository navigation
fix: resolve node components eagerly in dev to avoid 500 errors on in-flight reloads (#17554) - #17593
Closed
praveen-kumary wants to merge 1 commit into
Closed
praveen-kumary wants to merge 1 commit into
praveen-kumary wants to merge 1 commit into
Conversation
…-flight reloads (sveltejs#17554) Signed-off-by: praveen-kumary <praveenkumar2000y@gmail.com>
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/72beac921aa398a85b3496955d857efe83d39f7aOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 72beac9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Comment on lines
+101
to
+106
| const component_promise = resolve( | ||
| vite, | ||
| vite_dev_server, | ||
| runner, | ||
| /** @type {string} */ (node.component) | ||
| ).then(({ module_node, module }) => { |
Contributor
There was a problem hiding this comment.
Pages with ssr = false now evaluate their components on the server, causing valid browser-only module code to trigger server errors and Vite error overlays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #17554
What changed
In
packages/kit/src/exports/vite/dev/generate_manifest.js,node.serverandnode.universalare resolved immediately when building node manifests, whilenode.componentwas wrapped in an async getter that deferred resolution untilrender_responseafter allload()functions finished.If a server module is edited while an asynchronous
load()is in flight, Vite triggers an SSR program reload. Whenrender_responselater evaluated the deferrednode.component(), the component was loaded under a freshsvelte/internal/servergeneration while the request'sroot.svelteand renderer were initialized under the previous generation, resulting in a 500 error (Cannot read properties of null (reading 'function')).This patch starts resolving
node.componentas soon as the node is constructed so the component is imported in the same module generation asroot.svelteand the server renderer.Tests
pnpm check.pnpm test:unit(1,123 passed across 76 suites).