Skip to content

fix(otp): dummy signup password must satisfy minimum_password_length (fixes #2456) #2717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepshekhardas wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(otp): dummy signup password must satisfy minimum_password_length (fixes #2456) #2717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/api/magic_link.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ func (a *API) MagicLink(w http.ResponseWriter, r *http.Request) error {
if isNewUser {
// User either doesn't exist or hasn't completed the signup process.
// Sign them up with temporary password.
password := crypto.GeneratePassword(config.Password.RequiredCharacters, 33)
password := crypto.GeneratePassword(config.Password.RequiredCharacters, max(config.Password.MinLength, 33))

signUpParams := &SignupParams{
Email: params.Email,
Expand Down
2 changes: 1 addition & 1 deletion internal/api/otp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ func (a *API) SmsOtp(w http.ResponseWriter, r *http.Request) error {
if isNewUser {
// User either doesn't exist or hasn't completed the signup process.
// Sign them up with temporary password.
password, err := password.Generate(64, 10, 1, false, true)
password, err := password.Generate(max(config.Password.MinLength, 64), 10, 1, false, true)
if err != nil {
return apierrors.NewInternalServerError("error creating user").WithInternalError(err)
}
Expand Down