fix(otp): dummy signup password must satisfy minimum_password_length (fixes #2456) - #2717
Open
deepshekhardas wants to merge 1 commit into
Open
fix(otp): dummy signup password must satisfy minimum_password_length (fixes #2456)#2717deepshekhardas wants to merge 1 commit into
deepshekhardas wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(otp): dummy signup password must satisfy minimum_password_length (fixes #2456)
OTP/magic-link signup creates the user with an internally generated
dummy password of fixed length (33 for email magic link, 64 for SMS).
When
minimum_password_lengthis configured higher than that (e.g.100),
validateSignupParamsrejects the just-generated password withweak_password422, breaking passwordless signup entirely.Generate the dummy password with
max(config.Password.MinLength, <default>)so passwordless signup worksregardless of the configured minimum.