Skip to content

fix(start): make solid-js a peer dependency #2343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lxsmnsyc wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −4
Open

fix(start): make solid-js a peer dependency #2343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f40076a
fix(start): make solid-js a peer dependency
lxsmnsyc Oct 13, 2026
dc871b7
Merge branch 'main' into fix/solid-js-peer
lxsmnsyc Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/solid-js-peer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@solidjs/start": patch

@brenelz brenelz Oct 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this should be a minor version bump?

---

Make `solid-js` a peer dependency instead of a regular one. When an app's `solid-js` version was outside the range SolidStart asked for, package managers installed a second copy just for SolidStart. The two copies did not share reactive context, so client-side navigation broke with `TypeError: Cannot read properties of null (reading 'push')`. SolidStart now uses the app's `solid-js`, and a version outside the supported range shows up as a peer dependency warning at install time.
3 changes: 2 additions & 1 deletion packages/start/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,19 +79,20 @@
"seroval": "^1.6.8",
"seroval-plugins": "^1.6.8",
"shiki": "^4.3.1",
"solid-js": "^1.9.15",
"srvx": "^0.12.4",
"terracotta": "^1.2.4",
"vite-plugin-solid": "^2.11.13"
},
"devDependencies": {
"@types/babel__core": "^7.20.5",
"@types/node": "^26.1.1",
"solid-js": "^1.9.15",
"vite": "^8.1.5",
"vitest": "^4.1.10"
},
"peerDependencies": {
"@solidjs/router": ">=0.16.0 <2.0.0-0",
"solid-js": "^1.9.15",
"vite": "^8 || ^9"
},
"peerDependenciesMeta": {
Expand Down
6 changes: 3 additions & 3 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading