Repository navigation
Conversation
@solidjs/start listed solid-js as a regular dependency. When an app's solid-js version was outside that range, package managers installed a second copy just for SolidStart. The two copies did not share reactive context, so client-side navigation failed with "Cannot read properties of null (reading 'push')" and no hint at the cause. Move solid-js to peerDependencies with the same range, like @solidjs/router and @solidjs/meta, and keep it in devDependencies for the package's own build and tests. Fixes #2286. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: dc871b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
brenelz
approved these changes
Oct 13, 2026
brenelz
reviewed
Oct 14, 2026
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@solidjs/start": patch | |||
Contributor
There was a problem hiding this comment.
so this should be a minor version bump?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2286.
@solidjs/startlistssolid-jsas a regular dependency (^1.9.14in 2.0.0,^1.9.15now). When an app'ssolid-jsversion is outside that range, package managers install a second copy just for SolidStart. The two copies do not share reactive context. In the report, client-side navigation updated the URL but kept the old page, withTypeError: Cannot read properties of null (reading 'push')and nothing pointing at the cause.1.x never listed
solid-jsat all, so it always used the app's copy. This is why the reporter only hit it after migrating to v2.Fix
Move
solid-jstopeerDependencieswith the same range, as@solidjs/routerand@solidjs/metaalready do, and keep it indevDependenciesfor the package's own build and tests. A version outside the range now shows up as a peer dependency warning at install time instead of a second copy.For npm users, a
solid-jsversion outside the range now failsnpm installwith a peer conflict instead of installing quietly. Apps in range are not affected.Testing
A standalone app outside the monorepo (pnpm,
@solidjs/router0.16.3, vite 8.2.1, nitro), production build, clicking a link from/to/aboutin a browser:@solidjs/startsolid-js/,Cannot read properties of null (reading 'push')unmet peer solid-jsSolid's "multiple instances" warning is only in its dev build, so it did not appear in the production run.
In the repo:
@solidjs/starttest:ci(213 tests),typecheck,validate-importsandbuildpass, andapps/testsunit tests and Playwright e2e (42) pass. The lockfile change only movessolid-jsfrom start'sdependenciesto itsdevDependencies.Not in this PR
@solidjs/metais also a regular dependency of start, but nothing in the package imports it. It could be removed separately.🤖 Generated with Claude Code