Repository navigation
Conversation
mdydek
marked this pull request as draft
October 6, 2026 17:21
3 of 7 tasks
WPT non-regression comparisonPASS — no regressions · 0 improved section(s) · overall 3427 → 3427 (0) Unchanged sections (28)
Baseline: Workflow run · this comment is updated on every push. |
mdydek
marked this pull request as ready for review
October 8, 2026 13:10
closetcaiman
self-requested a review
October 20, 2026 15:00
closetcaiman
requested changes
Oct 21, 2026
Comment on lines
+1032
to
+1034
| Both `adts` and `flac` formats stays decodable after an app crash, but only former is lossy. | ||
| `Adts` accepts only the sample rates an ADTS header can express: 7350, 8000, 11025, 12000, 16000, 22050, 24000, 32000, 44100, 48000, 64000, 88200 and 96000 Hz. | ||
| ::: |
Member
There was a problem hiding this comment.
Is this the limitation of OS API or our decision? If it is dictated by OS maybe it's better to point to a specific doc instead of listing everything.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original idea from #1319 reimplemented after #1183 merged. Confirmed that the recording retrieved after killing app is fully decodable.
Introduced changes
Checklist