Repository navigation
Conversation
WPT non-regression comparisonPASS — no regressions · 0 improved section(s) · overall 3427 → 3427 (0) Unchanged sections (28)
Baseline: Workflow run · this comment is updated on every push. |
3 of 7 tasks
Member
|
thank you |
mdydek
merged commit Oct 13, 2026
6701fc2
into
software-mansion:feat/adts-codec-support
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1333, targeting
feat/adts-codec-support.Buffered ADTS writes can succeed even when the following flush fails. Report
fflushandfcloseerrors, and count frame bytes only after a successful flush. Own the output file with a closing smart pointer so an early codec-drain failure also releases it when the backend is destroyed.Document ADTS
.aacconcatenation, matching sample rates/channel configurations, and removal of incomplete trailing frames. Preserve the feature branch's enum ordering and per-frame flush behavior.Validation:
AndroidEncoder.cpptranslation unit for arm64/API 24, using React Native 0.87.0 JSI headers.git diff --checkpasses.