Repository navigation
Name one reporting channel order in SECURITY.md; survive an API rate limit in install.sh - #37
Merged
Merged
Conversation
The private-reporting paragraph was added above the old email instruction, so the policy named security@simtabi.com twice and read as two competing instructions. Private reporting is the preferred channel and the address is its fallback; the rest of the section now applies to either.
The GitHub API allows 60 unauthenticated requests an hour per IP, so a shared NAT or a CI runner can find it spent: the macOS installer job failed twice in a row with curl exit 56 on a 403. The web redirect is not counted against that limit and names the same tag. Keeping the unauthenticated call first preserves the bash 3.2 empty-array path the job exists to exercise.
imanimanyara
changed the title
imanimanyara
added a commit
that referenced
this pull request
Oct 3, 2026
install.ps1 resolved the version through the GitHub API only, so a spent unauthenticated rate limit (60 requests an hour per IP) failed the install on Windows, as it did on macOS before #37. It now tries the API, then reads the tag from the releases/latest redirect, with redirects disabled so the Location header reads the same on PowerShell 5.1 and 7. The Windows installer was parsed in CI and never run. The test job now runs it on windows-latest twice: once as shipped, and once with the API URL broken so the fallback is what resolves the version. The step refuses to run the second case if the URL substitution matched nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The private-reporting paragraph was added above the old email instruction, so SECURITY.md named security@simtabi.com twice and read as two competing instructions. It now gives private vulnerability reporting first and the address once, as the fallback; the rest of the section applies to either channel.