Repository navigation
Fall back to the releases/latest redirect in install.ps1 too - #40
Merged
Merged
Conversation
install.ps1 resolved the version through the GitHub API only, so a spent unauthenticated rate limit (60 requests an hour per IP) failed the install on Windows, as it did on macOS before #37. It now tries the API, then reads the tag from the releases/latest redirect, with redirects disabled so the Location header reads the same on PowerShell 5.1 and 7. The Windows installer was parsed in CI and never run. The test job now runs it on windows-latest twice: once as shipped, and once with the API URL broken so the fallback is what resolves the version. The step refuses to run the second case if the URL substitution matched nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install.ps1 resolved the version through the GitHub API only, so a spent
unauthenticated rate limit (60 requests an hour per IP) failed the install on
Windows, as it did on macOS before #37. It now tries the API, then reads the
tag from the releases/latest redirect, with redirects disabled so the Location
header reads the same on PowerShell 5.1 and 7.
The Windows installer was parsed in CI and never run. The test job now runs it
on windows-latest twice: once as shipped, and once with the API URL broken so
the fallback is what resolves the version. The step refuses to run the second
case if the URL substitution matched nothing.