Repository navigation
fix: check --only and --exclude before tool setup in extension fix and format - #1624
Merged
Malte Janz (MalteJanz) merged 1 commit intoSep 28, 2026
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Malte Janz (MalteJanz)
approved these changes
Sep 28, 2026
Malte Janz (MalteJanz)
merged commit Sep 28, 2026
3d8aba5
into
feat/add-exclude-flag-to-extension-format-and-fix
5 checks passed
Malte Janz (MalteJanz)
deleted the
fix/extension-select-tools-before-setup
branch
September 28, 2026 09:38
Malte Janz (MalteJanz)
pushed a commit
that referenced
this pull request
Sep 28, 2026
Malte Janz (MalteJanz)
pushed a commit
that referenced
this pull request
Sep 28, 2026
Malte Janz (MalteJanz)
added a commit
that referenced
this pull request
Sep 28, 2026
* feat: add exclude flag to extension format and fix * fix: check --only and --exclude before tool setup in extension fix and format (#1624) * fix: toolDirectory and setuptools call ordering for extension fix + format --------- Co-authored-by: Lena Forlin <118278183+moshimorschi@users.noreply.github.com>
12 of 46 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
extension fixandextension formatnow check--onlyand--excludebeforeSetupToolsruns and before the extension is parsed.PreRunEis gone,SetupToolsis called inRunEright before the tools start.Why?
Same order as
extension validate. On a cold cache a typo in a tool name currently triggers the tool install first and reports the error afterwards. Not urgent, the install is cached anyway; this just gives the error straight away.How was this tested?
go test ./cmd/extension ./cmd/project ./internal/verifier, plus manual runs with a bad--excludeon an empty cache: the error now comes before any setup.Related issue or discussion
Follow-up to #1616, targets its branch so it can be merged into it or dropped.