Repository navigation
fix(test): keep resolver cache assertions PHPStan 2.2 safe - #260
Merged
Merged
Conversation
PHPStan 2.2 reports a second assertSame() on the same resolve() call expression as always true, because the first assertion narrowed that expression. Store both results before asserting; the single repository read is still proven by expectedReads.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Björn Meyer (BrocksiNet)
requested a review
from Dominik Grothaus (dgrothaus-sw)
September 25, 2026 11:24
Dominik Grothaus (dgrothaus-sw)
approved these changes
Sep 28, 2026
Lukas Rump (lukasrump)
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPStan resolves to
2.2.xnow (^2.1constraint, no committed lock), and it reports two errors inSalesChannelTypeResolverTestthat turnphp-quality,sdk-main-compatibilityandfuture-compatibilityred on every open PR (#249, #253, #258, #259):The caching tests call
assertSame(X, $resolver->resolve('id'))twice in a row. The first assertion narrows the$resolver->resolve('id')expression, so PHPStan treats the second as already known. Markingresolve()@phpstan-impuredoes not help; 2.2 still flags back-to-back asserts on the same call expression, and it would add an "impure without side effects" error on the static test fixture.The tests now store both results before asserting. The single repository read remains proven by
expectedReads: 1.