Skip to content

fix: use 1.0 currency factor for same-currency Magento orders #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dennis Garding (DennisGarding) merged 2 commits into from
Aug 12, 2026
Merged

fix: use 1.0 currency factor for same-currency Magento orders #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed56e8a
fix: use 1.0 currency factor for same-currency Magento orders
DennisGarding Aug 10, 2026
823d8c3
Merge branch 'trunk' into 18905/fix-magento-currency-factor
DennisGarding Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Profile/Magento/Converter/OrderConverter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,9 @@ public function convert(array $data, Context $context, MigrationContextInterface

$this->convertValue($converted, 'orderNumber', $data['orders'], 'increment_id');
$this->convertValue($converted, 'currencyFactor', $data['orders'], 'store_to_order_rate', self::TYPE_FLOAT);
if (($converted['currencyFactor'] ?? 0.0) <= 0.0) {
$converted['currencyFactor'] = 1.0;
}
$this->convertValue($converted, 'orderDateTime', $data['orders'], 'created_at', self::TYPE_DATETIME);

$this->convertCurrency($converted, $data);
Expand Down
14 changes: 14 additions & 0 deletions tests/Profile/Magento2/Converter/Magento2OrderConverterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@ public function testConvert(): void
static::assertNotNull($converted);
static::assertNull($convertResult->getUnmapped());
static::assertArrayHasKey('id', $converted);
static::assertSame(1.0, $converted['currencyFactor']);
static::assertNotNull($convertResult->getMappingUuid());
static::assertSame($this->storeUuid, $converted['salesChannelId']);
$price = $converted['price'];
Expand All @@ -289,6 +290,19 @@ public function testConvert(): void
static::assertNotNull($converted['totalRounding']);
}

public function testConvertWithZeroCurrencyFactor(): void
{
$context = Context::createDefaultContext();
$orderData = require __DIR__ . '/../../../_fixtures/order_data.php';
$orderData[0]['orders']['store_to_order_rate'] = '0.0000';

$convertResult = $this->orderConverter->convert($orderData[0], $context, $this->migrationContext);
$converted = $convertResult->getConverted();

static::assertNotNull($converted);
static::assertSame(1.0, $converted['currencyFactor']);
}

public function testConvertWithInvalidShippingMethod(): void
{
$context = Context::createDefaultContext();
Expand Down