Repository navigation
fix: use 1.0 currency factor for same-currency Magento orders - #66
Merged
Dennis Garding (DennisGarding) merged 2 commits intoAug 12, 2026
Merged
Conversation
Dennis Garding (DennisGarding)
marked this pull request as draft
August 10, 2026 13:46
Dennis Garding (DennisGarding)
marked this pull request as ready for review
August 11, 2026 05:33
Lars Kemper (larskemper)
approved these changes
Aug 11, 2026
Jozsef Damokos (jozsefdamokos)
approved these changes
Aug 11, 2026
Dennis Garding (DennisGarding)
deleted the
18905/fix-magento-currency-factor
branch
August 12, 2026 08:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: shopware/shopware#18905
1. Why is this change necessary?
Magento stores
store_to_order_rateas0.0000for orders placed in the shop's base currency. The migration currently copies this value directly to Shopware'scurrencyFactor, resulting in orders with a currency factor of0.2. What does this change do, exactly?
Uses
1.0as the fallback whenstore_to_order_rateis missing or less than or equal to zero. Valid currency conversion rates remain unchanged.Adds regression coverage for zero and regular currency factors.
Wait for: #65 to fix the PHPStan pipeline: