Repository navigation
test: probe whether the PHPUnit job detects a truncated suite - #223
Closed
Jozsef Damokos (jozsefdamokos) wants to merge 1 commit into
Closed
Jozsef Damokos (jozsefdamokos) wants to merge 1 commit into
Jozsef Damokos (jozsefdamokos) wants to merge 1 commit into
Conversation
This was referenced Sep 9, 2026
Adds one test whose exit(0) terminates the PHPUnit process with a success exit code, so the "Run PHPUnit" step of .github/workflows/action-phpunit.yml sees a green run after only a random prefix of the suite executed. Probe for shopware/shopware#18667 — do not merge.
Jozsef Damokos (jozsefdamokos)
force-pushed
the
test/demo-phpunit-completion-guard
branch
from
September 9, 2026 19:54
9140013 to
3367108
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probe for shopware/shopware#18667 — do not merge.
1. Why is this change necessary?
shopware/shopware#18667 asks us to give the after-sales plugin PHPUnit jobs the same "the suite really ran" safety net that the platform got in shopware/shopware#18675. Before choosing between the two options in the issue (reuse
.github/actions/phpunit-run/action.yaml, or reimplement the check here), we need evidence about what this repository'sPHPUnitjob actually detects today.2. What does this change do, exactly?
Adds a single test,
tests/CompletionGuardDemoKillerTest.php, whoseexit(0)terminates the PHPUnit process with a success exit code — the shopware/shopware#18560 incident class.phpunit.xml.distruns the suite inexecutionOrder="random", so the process dies after an arbitrary prefix of the 234 test classes.The
Run PHPUnitstep of.github/workflows/action-phpunit.ymlonly inspects the exit code, so the outcome of thePHPUnitjob of theIntegrationworkflow answers the question directly:Shopware\Core\Test\PHPUnit\CompletionGuard, registered fromTestBootstrapper::bootstrap()whichtests/TestBootstrap.phpcalls, already covers this repository through thetrunkplatform this job installs. The failure message is then "PHPUnit terminated before the test runner finished the suite".3. Describe each step to reproduce the issue or behaviour.
Integration/PHPUnitjob run.Run PHPUnitstep output against the two cases above.5. Checklist