Repository navigation
fix(tests): exit non-zero when the TestBootstrapper cannot be found - #224
Merged
Jozsef Damokos (jozsefdamokos) merged 3 commits intoSep 10, 2026
Merged
Conversation
exit('message') terminates the process with status 0, so a failure to locate
the platform TestBootstrapper left the PHPUnit job green with not a single
test executed. The three fallback paths exist because the platform layout
already moved twice (shopware/platform monorepo, shopware/core split,
in-tree), so a third move would have silently greened this job.
CompletionGuard cannot cover this: it is registered inside
TestBootstrapper::bootstrap(), which is never reached here.
Refs shopware/shopware#18667
Jozsef Damokos (jozsefdamokos)
force-pushed
the
fix/phpunit-bootstrap-exit-code
branch
from
September 9, 2026 19:54
d3aa465 to
7d607e2
Compare
Jozsef Damokos (jozsefdamokos)
marked this pull request as ready for review
September 9, 2026 19:55
Only the Integration workflow opts in: it runs on pull requests and on push to trunk, so Codecov gets the trunk baseline its project status compares against. Nightly runs the same suite and would add nothing. .github/codecov.yml sets the project and patch thresholds. Neither status is a required check in this repository, so a coverage drop reports red without blocking a merge. CODECOV_TOKEN is an organization secret already available here, so no new secret is needed. Refs shopware/shopware#18667
SwagCmsExtensions, SwagSocialShopping and SwagPublisher all upload clover from an absolute working directory with root_dir set, and so does shopware/github-actions/phpunit. Matching that keeps the four migration repositories from being a fifth dialect, and clover is the format the PHPUnit shipped with Shopware 5 also understands, so every repository can use one. Drops .github/codecov.yml: no other plugin ships one, Codecov posts both statuses from its own defaults without it, and the file only replaced those defaults with the platform's tolerances. It also failed the admin lint job, which prettier-checks .github/**/*.yml. Replaces #[CoversClass(MigrationLogEntry::class)] with the abstract class the test actually exercises. MigrationLogEntry is an interface, which PHPUnit rejects as a coverage target, and with failOnWarning="true" that turned the suite red for all 37 tests in the class as soon as coverage was switched on.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Lars Kemper (larskemper)
approved these changes
Sep 10, 2026
Dennis Garding (DennisGarding)
approved these changes
Sep 10, 2026
Jozsef Damokos (jozsefdamokos)
deleted the
fix/phpunit-bootstrap-exit-code
branch
September 10, 2026 09:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exit('message')terminates with status 0, so failing to locate the platformTestBootstrapperleft thePHPUnitjob green with zero tests executed — this writes to stderr and exits1instead.Part of shopware/shopware#18667.