Skip to content

Settings: explain read-only Apple Health water import - #2656

Merged
ryanbr merged 1 commit into
ryanbr:mainfrom
kavemang:agent/hydration-health-import-description-2465
Oct 3, 2026
Merged

ryanbr merged 1 commit into
ryanbr:mainfrom
kavemang:agent/hydration-health-import-description-2465

Conversation

@kavemang

@kavemang kavemang commented Oct 3, 2026 •

Copy link
Copy Markdown

What this PR does

Hydration tracking currently says “Nothing is synced” on Apple even though enabling it also allows Apple Health water imports on iOS. Replace that description with local-storage copy and explain the read-only Health import beneath the iOS switch, including the connection/read-access prerequisites. Drinks recorded in NOOP are not written to Health.

Both descriptions cover all 10 Apple catalog locales and use existing design tokens. macOS does not show the iOS-only Health note. No import behavior or setting changes. Android is unchanged because this report concerns Apple Health; the active Android Settings localization work in #2498 is left to its author. This covers only the hydration row of the broader issue.

Type of change

  • Bug fix

How it was tested

  • Diff-scoped i18n audit, doc-comment hygiene, JSON catalog parse/comparison and whitespace checks pass. Only the replaced description and two new entries differ in the catalog.
  • Linux Swift syntax parse passes; it does not validate SDK typing. Exact-head CI passes: both Apple SDK builds, Tools, i18n, hygiene and Android checks (6/6). Universal macOS build and StrandTests passed: 2,269 tests, two skipped, zero failures. iOS Simulator SDK build and String Catalog compilation passed.
  • Full local Tools Python suite passed: 338 tests, zero failures. Tools CI includes 50 parity acceptance, 2 R-R contract, 153 core Tools and 234 linux-capture tests. Android APK checks also pass; Android unit-test result was FROM-CACHE, with no Android files changed. No new test added for a reversible copy change.
  • Draft pending manual iOS/macOS layout and translation review. No device, Health permission/import or hardware interaction performed; import logic is unchanged.

Checklist

  • UI uses existing design tokens
  • No generated output, secrets, storage or BLE changes
  • Follows contributor conventions

Related issues

Refs #2465

@kavemang
kavemang marked this pull request as ready for review October 3, 2026 17:55
@ryanbr
ryanbr merged commit 20f6847 into ryanbr:main Oct 3, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants